Support multiple spec #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euforia
requested changes
Dec 11, 2018
pkg/thrap/deployments.go
Outdated
| @@ -33,15 +33,15 @@ type Deployments struct { | |||
| } | |||
|
|
|||
| // NewDeployments returns a new Deployments instance for a given project | |||
| func NewDeployments(t *Thrap, proj pb.Project) *Deployments { | |||
| func NewDeployments(t *Thrap, proj pb.Project, version string) *Deployments { | |||
There was a problem hiding this comment.
NewDeployments manages all deploys for a project. Version should not be in the constructor.
pkg/thrap/deployments.go
Outdated
| // Descriptor returns the current loaded deployment descriptor | ||
| func (d *Deployments) Descriptor() *pb.DeploymentDescriptor { | ||
| return d.desc | ||
| } | ||
|
|
||
| // SetDescriptor sets the deployment descriptor in the store. | ||
| func (d *Deployments) SetDescriptor(desc *pb.DeploymentDescriptor) error { | ||
| err := d.descs.Set(d.proj.ID, desc) | ||
| func (d *Deployments) SetDescriptor(desc *pb.DeploymentDescriptor, version string) error { |
There was a problem hiding this comment.
Change to SetDescriptor(string, *pb.DeploymentDescriptor)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.