-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
An exception case during run Base32 gtest #107
Labels
Comments
YoungSeokHong
added a commit
to YoungSeokHong/euphony
that referenced
this issue
Oct 9, 2021
It's my pleasure 😄 |
I think you have found a solution to this problem. 👍 euphony/euphony/src/main/cpp/core/source/Base64.cpp Lines 79 to 86 in 5e1ee90
|
Thanks for your notice! I'll update Base64 too. 😀 |
YoungSeokHong
added a commit
to YoungSeokHong/euphony
that referenced
this issue
Oct 10, 2021
YoungSeokHong
added a commit
to YoungSeokHong/euphony
that referenced
this issue
Oct 10, 2021
Co-authored-by: JK Park <kuro11pow2@gmail.com>
Merged
designe
pushed a commit
that referenced
this issue
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Thanks to @kuro11pow2 , I find an bug during Base32 gtest!
It is a special case because it goes
1
00000000000000000000
00000000000000000000
. And when00000000000000000000
enters thebitsToBase32
function, nothing happens because of the condition of while loopwhile(value != 0)
.The best way I think is to add exception code to catch
00000000000000000000
input case.Because it is an unusual case.
I'm really appreciate to 'kuro11pow2' for making a sharp test case.
Please give me some solution or I'll make PR with my solution.
The text was updated successfully, but these errors were encountered: