EuphonyTxPanel Component & Documentation #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zion830
commented
Sep 18, 2022
Comment on lines
39
to
40
| // TODO : EuTxManager() should be changed to use singleton pattern | ||
| val viewModel: TxPanelViewModel = viewModel(factory = TxPanelViewModelFactory(EuTxManager())) |
yeonns
reviewed
Sep 19, 2022
Comment on lines
+40
to
+41
| #### Options | ||
|
|
There was a problem hiding this comment.
WoW! So nice options 👍 It will help to customize EuphonyTxPanel!
Comment on lines
39
to
40
| // TODO : EuTxManager() should be changed to use singleton pattern | ||
| val viewModel: TxPanelViewModel = viewModel(factory = TxPanelViewModelFactory(EuTxManager())) |
| TextField( | ||
| modifier = Modifier | ||
| .weight(1f) | ||
| .fillMaxHeight(), |
There was a problem hiding this comment.
I tested your EuphonyTxPanel, and even if row has panelHeight, your TextField and Button has fillMaxHeight(), so it fills whole screen. So, I think TextField and Button should have panelHeight.
There was a problem hiding this comment.
Thank you for letting me know! I fixed it
15c0d37
designe
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue : #231
EuTxManager. It also provides several options to custom design.Screenshot