Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HALO cloud mask files: engine=netcdf #61

Merged
merged 3 commits into from
Apr 6, 2021
Merged

HALO cloud mask files: engine=netcdf #61

merged 3 commits into from
Apr 6, 2021

Conversation

tmieslinger
Copy link
Collaborator

add engine=netcdf4 to all HALO cloud mask files.
The cloud mask files use signed bytes which depend on this hack, while opendap does not support signed bytes.

@tmieslinger tmieslinger requested a review from d70-t April 6, 2021 08:30
d70-t
d70-t reviewed Apr 6, 2021
View reviewed changes
Copy link
Contributor

@d70-t d70-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the missing newlines at the end of several files, this looks simple and is a very welcome change.

HALO/specmacs/cloudmaskSWIR.yaml Outdated Show resolved Hide resolved
HALO/kt19_cloudmask.yaml Outdated Show resolved Hide resolved
HALO/unified/Radar_cloud_mask_unified.yaml Outdated Show resolved Hide resolved
HALO/velox_cloudmask.yaml Outdated Show resolved Hide resolved
HALO/wales/wales_cloudtop.yaml Outdated Show resolved Hide resolved
@tmieslinger
Copy link
Collaborator Author

Ups... thanks for the "newline" hint. I added newlines to the end on the mentioned files.

d70-t
d70-t approved these changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@d70-t d70-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change. Looks alright now 🎉

@tmieslinger tmieslinger merged commit 9463699 into eurec4a:master Apr 6, 2021
@tmieslinger tmieslinger deleted the engine_netcdf branch April 6, 2021 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d70-t d70-t d70-t approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmieslinger @d70-t