Feat/MET-5796_MET-5803 rework register user #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeortizquan
changed the title
stzanakis
requested changes
Mar 4, 2024
There was a problem hiding this comment.
Some more things that can be cleaned up:
- metis.common.config.properties.zoho.ZohoConfigurationProperties Can be removed.
- eu.europeana.metis.utils.CommonStringValues#COULD_NOT_PARSE_USER_RETURNED_FROM_ZOHO can be removed.
- pom.xml:229 dependency to metis-common-zoho can be removed.
Some things to not forget:
- Don't forget to update metis-configuration for test/acceptance
- Don't forget to create subtask for updating metis-configuration on the release ticket.
...st/src/main/java/eu/europeana/metis/authentication/rest/config/ApplicationConfiguration.java
Show resolved
Hide resolved
...n-service/src/main/java/eu/europeana/metis/authentication/service/AuthenticationService.java
Outdated
Show resolved
Hide resolved
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.