feat: update item page design w/ data provider section #1912
Conversation
|
JIRA ticket: EC-6178 |
|
Preview deployment: https://pr-1912.portal-js.dev.eanadev.org/ |
rwd
changed the title
| namePrefLanguage() { | ||
| return this.getPrefLanguage('edmDataProvider', { def: [{ prefLabel: this.dataProvider }] }); | ||
| }, | ||
| nativeName() { |
There was a problem hiding this comment.
Is this really the native name if there is no entity?
There was a problem hiding this comment.
It depends on the data from the record.
Changed the variable name to reflect this.
However I wonder if we need this at all.
If not it would also mean we don't need the getPrefLanguage method in a mixin, which would address your other comment regarding moving the prop/parameter.
| if (['edmDataProvider', 'edmProvider'].includes(fieldName)) { | ||
| nativeLocale = this.getNativeLocale(fieldData); | ||
| } | ||
| return nativeLocale || this.metadataLanguage || this.$i18n.locale; |
There was a problem hiding this comment.
I don't think we should refer to this.metadataLanguage here without any context of where it's come from.
Either:
- Move the
metadataLanguageprop into the mixin; or - Make
metadataLanguagea parameter of the function
I'd suggest option 2.
| :items="items" | ||
| view="explore" | ||
| class="mb-0" | ||
| data-qa="similar items" | ||
| /> | ||
| <b-button |
| variant="outline-secondary" | ||
| @click="keycloakLogin" | ||
| > | ||
| {{ $t('related.items.loginForMore', { other: items.length ? 'other' : ''}) }} |
There was a problem hiding this comment.
This is not going to translate properly.
There was a problem hiding this comment.
And space is needed before one of the }
|
Kudos, SonarCloud Quality Gate passed! |
rwd
deleted the
feat/EC-6178-item-page-provider-section-entities-from-page
branch
No description provided.