-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: log search interactions to APM #2036
Conversation
JIRA ticket: EC-6318 |
Preview deployment: https://pr-2036.portal-js.dev.eanadev.org/ |
So that they may be used by onClickItem handler
As otherwise the APM agent discards it.
With SSR logging deferred to client-side, for session ID from sessionStorage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The user buttons and the copyright and type info section in the list view also cause events to fire when they're clicked on.
Adding an @click.stop=""
attribute to the wrapper div in portal/src/components/user/UserButtons.vue looks like it successfully prevents this from happening.
@lbiedinger to prevent clicking the user buttons from logging the search interaction, I have used @click.stop as you suggested, but put it into ItemPreviewCard instead of within UserButtons. |
Kudos, SonarCloud Quality Gate passed! |
Summary:
Detail:
vue-session-id
which generates a session ID withuuid
and stores it in sessionStorageelasticApmReporter
which:logApmTransaction
which:name
andlabels
properties for the transaction to log to APM, and stores it to the component datalogApmTransaction
to log any transaction object already stored in the component data, e.g. from server-side hydrationelasticApmReporter
mixin to log search interactions for fetching results and clicking a resultclick
andauxclick
events on the cards, used for the search result click logging