Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: client-only SearchInterface on collection page #2041

Merged
merged 3 commits into from
Aug 21, 2023

Conversation

LeoniePeters
Copy link
Contributor

@LeoniePeters LeoniePeters commented Aug 18, 2023

  • Two new env vars:
    • APP_SEARCH_COLLECTIONS_CLIENT_ONLY: Search for related items on the collections pages client-side only. If not enabled, items will be searched for server-side too.
    • APP_SEARCH_COLLECTIONS_DO_NOT_TRANSLATE: Prevent translation of search results, i.e. related items, on the collections pages, even for the locales set in APP_SEARCH_TRANSLATE_LOCALES.
  • SearchInterface has a new prop, doNotTranslate, which will prevent search translation from running even in the configured locales, and which CollectionPage will pass in based on APP_SEARCH_COLLECTIONS_DO_NOT_TRANSLATE env var
  • In search plugin, stop looking at app config for translation, and instead just look at supplied options, for translateLang param, which SearchInterface now supplies
  • Fix bug where search queries for facets would not include translation params, resulting in the number of items for the filter being out of sync with the number in the search results
    • NOTE: this fix is going to result in more translations being requested of the API...

@github-actions
Copy link

Preview deployment: https://pr-2041.portal-js.dev.eanadev.org/

@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@rwd rwd merged commit b3318ad into master Aug 21, 2023
16 of 17 checks passed
@rwd rwd deleted the chore/csr-collections-search-interface branch August 21, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants