Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: landing page image card group #2047

Merged
merged 10 commits into from
Aug 29, 2023
Merged

feat: landing page image card group #2047

merged 10 commits into from
Aug 29, 2023

Conversation

LeoniePeters
Copy link
Contributor

@LeoniePeters LeoniePeters commented Aug 24, 2023 •
edited
Loading

  • Split ImageWithAttribution component into a container and sub component to reuse without the container + jumbotron wrappers
  • Add srcset and sizes attributes to ImageOptimised to pass in responsive images
  • Add new LandingImageCard and LandingImageCardGroup components

@github-actions
Copy link

JIRA ticket: EC-6411

@github-actions
Copy link

Preview deployment: https://pr-2047.portal-js.dev.eanadev.org/

@sonarcloud
Copy link

sonarcloud bot commented Aug 29, 2023 •
edited
Loading

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@lbiedinger lbiedinger merged commit 172bf29 into master Aug 29, 2023
17 of 18 checks passed
@lbiedinger lbiedinger deleted the feat/EC-6411-image-card-group branch August 29, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbiedinger lbiedinger lbiedinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeoniePeters @lbiedinger