Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: mv truncate filter to a mixin #2265

Merged
merged 3 commits into from
Apr 12, 2024
Merged

refactor: mv truncate filter to a mixin #2265

merged 3 commits into from
Apr 12, 2024

Conversation

rwd
Copy link
Contributor

@rwd rwd commented Mar 28, 2024 •
edited
Loading

  • in prep for Vue 3, which has no filters
  • add unit tests, which filter didn't have
  • drop the ellipsis and list separator formatting strings from the English lang file, as the other UI languages all just have the same symbol anyway

@github-actions GitHub Actions
Copy link

JIRA ticket: EC-6714

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2024

Preview deployment: https://pr-2265.portal-js.dev.eanadev.org/

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@lbiedinger lbiedinger merged commit aee98dd into master Apr 12, 2024
17 checks passed
@lbiedinger lbiedinger deleted the refactor/EC-6714-refactor-vue-filter-truncate branch April 12, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbiedinger lbiedinger lbiedinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rwd @lbiedinger