Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[irteus/irtglc.c] add irtglc.c (transpose-image-rows in C code) #388

Merged
merged 1 commit into from Jul 20, 2016
Merged

[irteus/irtglc.c] add irtglc.c (transpose-image-rows in C code) #388

merged 1 commit into from Jul 20, 2016

Conversation

furushchev
Copy link
Member

@furushchev furushchev commented Jul 14, 2016 •
edited

support transpose image rows in native code.

  • create irteus/irtglc.c file and add CTRANSPOSE_IMAGE_ROWS.
  • add gl::transpose-image-rows for interface in euslisp.
  • add testcode

@furushchev furushchev mentioned this pull request Jul 14, 2016
Closed
@furushchev furushchev changed the title [irteus/irtglc.c] add irtglc.c [irteus/irtglc.c] add irtglc.c (transpose-image-rows in C code) Jul 14, 2016
@k-okada
Copy link
Member

k-okada commented Jul 14, 2016

please bench mark with eusilsp code and c code

◉ Kei Okada

On Thu, Jul 14, 2016 at 7:43 PM, Furushchev notifications@github.com
wrote:

support transpose image rows in native code.

You can view, comment on, or merge this pull request online at:

#388
Commit Summary

  • [irteus/irtglc.c] add irtglc.c

File Changes

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#388, or mute the thread
https://github.com/notifications/unsubscribe/AAeG3EC7kPXGWczCKTQb8DXS72w7goGjks5qVhLYgaJpZM4JMTZh
.

@furushchev
Copy link
Member Author

furushchev commented Jul 14, 2016 •
edited

@k-okada about 0.33 sec to 0.05 sec in PR2 c1 computer.

@k-okada
Copy link
Member

k-okada commented Jul 14, 2016

If this is copied from somewhere please add link

@furushchev
Copy link
Member Author

furushchev commented Jul 14, 2016 •
edited

benchmarked again (on Macbook Pro Retina 10,1)

===== 10 transpose in eus (compiled) ======
;; time -> 1.73079[s]

===== 10 transpose in eus (not compiled) ======
;; time -> 25.5784[s]

===== 10 transpose in C ======
;; time -> 0.000631[s]

code: https://gist.github.com/furushchev/3832ffbb13503f5f7372b39e42a07e2f

Code Time (s) Ratio
Lisp 25.5784 1
Lisp (Compiled) 1.73079 2742
C (defforeign) 0.000631 40536

@furushchev furushchev force-pushed the irtglc branch 4 times, most recently from 98dd253 to 161a507 Compare July 14, 2016 14:48
@furushchev
Copy link
Member Author

@k-okada

If this is copied from somewhere please add link

mostly from https://github.com/jsk-ros-pkg/euslib/blob/346179108d5930e51e229388772e0c0e297efd47/jsk/jskc.c#L49

@furushchev furushchev force-pushed the irtglc branch 6 times, most recently from 5a64618 to cb8a7dd Compare July 15, 2016 07:05
@furushchev
- [irteus/irtglc.c,irtues/irtext.l,Makefile] add irtglc.c / implement…
341bcae 
… function for transpose image

- [irteus/irtgl.l] add interface for transpose image function in irtglc.c; replace lisp code for transpose image with C code.
- [irteus/test/rendering.l] add test for transpose
- [irteus/test/pr2.png] add test image
@furushchev
Copy link
Member Author

@k-okada Please review implementation and test codes, then merge if there is no problem.

@k-okada k-okada merged commit 6fbf4a5 into euslisp:master Jul 20, 2016
@k-okada
Copy link
Member

k-okada commented Jul 20, 2016

LGTM

@furushchev furushchev deleted the irtglc branch July 20, 2016 02:14
@furushchev
Copy link
Member Author

@k-okada Thank you for reviewing and merging!

iory pushed a commit to iory/jskeus that referenced this pull request Mar 22, 2018
@iory
- [irteus/irtglc.c,irtues/irtext.l,Makefile] add irtglc.c / implement…
8f017d2 
… function for transpose image (euslisp#388)

- [irteus/irtgl.l] add interface for transpose image function in irtglc.c; replace lisp code for transpose image with C code.
- [irteus/test/rendering.l] add test for transpose
- [irteus/test/pr2.png] add test image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@furushchev @k-okada