Conf file isn't generated #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default value was not working. I set description from controller and that worked for og:description, but the meta tag description content was empty for {!! Meta::tag('description'); !!}.
Meta tag description not working
removed share() method and replaced with singleton as per laravel 5.4^.
Added support for laravel 5.4
Use 'name' instead of 'property' for twitter card tags
Added fbAppId method
|
Do you have already a It's working fine: $> php artisan vendor:publish --provider="Eusonlito\LaravelMeta\MetaServiceProvider"
Copied File [/vendor/eusonlito/laravel-meta/src/config/config.php] To [/config/meta.php]
Publishing complete.Why a pull-request and not a simple issue? |
|
I created a pull request cause I fucked sorry... No I don't have a config/meta.php. I just copy it from vendors directory |
|
Are you using my package or @Torann fork? |
|
I'm using your package and I have discovered the problem :) With the autodiscover function of Laravel I don"t add provider and alias.... By adding them in config/app.php it works...... |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
php artisan vendor:publish --provider="Eusonlito\LaravelMeta\MetaServiceProvider"doesn't generate config file