New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vue3 Support? #626
Comments
Vue 3.0 is not even ready for production yet. euvl is also searching for maintainers, so I guess before that, no. I'm personally happy with Vue 2 and I think it will be at least one year until Vue 3 becomes production ready (or maybe even more!). |
See #586 for details on the maintainer search. |
Hi! |
It's not even stable yet, or better, it lacks documentation. Just go with
Vue 2 and you'll be fine.
Am Mi., 21. Okt. 2020 um 06:57 Uhr schrieb MCDis <notifications@github.com>:
… Hi!
vue 3 already released
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#626 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABD7E6JOJTTSHEJKWQSLR6LSL2WAJANCNFSM4RTCWTFQ>
.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Vue 3 is stable already and very well documented, including migration guide. From vuejs/vue-next:
So, Vue 3 is going to take the main distribution position soon. |
+1 for Vue3 support |
Hi, I'm the author of vue-final-modal and it supports Vue2 and Vue3. |
This doesn't have proper documentation to make it work with Vue 3. I may take up on writing a MR for Vue 3. |
@rafalolszewski94 Thanks for chiming in, I have a need for the same thing (v3 support). I will have a look at your project. |
I'm working on it here: https://github.com/rafalolszewski94/vue-js-modal/tree/vue3 Currently got working:
Will keep you guys posted 🤜 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@rafalolszewski94 Thanks for the fork. It's not published yet, is it? Unfortunately, vue-final-modal is not a drop-in replacement. |
bump |
Could someone merge rafalolszewski94 work and publish a new version for Vue 3 ? |
Anyone publish a new version yet? |
|
@rafalolszewski94 did you find a way to make it work ? |
any release? |
Any news? I've been trying vue final modal but it is a hell of a thing to make it work as i need. |
Make vue3 support please!!!!! |
Hey guys, I migrated to the aforementioned vue-final-modal. If you choose to do so yourself, this will make your life a little easier as it's not a drop-in replacement. When using vue-final-modal, you need to set the styling classes yourself. I copied the styling from vue-js-modal and merged it a little with the stuff explained in the step-by-step section of vue-final-modal:
Apply these to your vue-final-modal like this
A very basic example, to switch from a vue-js-modal like this:
do this
You can figure out the rest yourself (e.g. getting the params is a tiny bit different). To make it scrollable you probably have to style your modal yourself as there's no simple prop for it like in vue-js-modal. But I didn't use the prop and made it myself so I didn't have any trouble regarding that when migrating. Hope this helps! |
Is there anyone intested in migrating this module to Vue 3? |
Use Vue-Final-Modal |
If anyone is still looking for a drop-in replacement for the dynamic modals version (with stackable modals), try jenesius-vue-modal We wrote a quick wrapper so if we decide to switch again in the future it becomes a lot easier: import { config, pushModal, popModal } from 'jenesius-vue-modal'
config({
scrollLock: true,
animation: 'modal-list',
backgroundClose: true,
escClose: true
})
export async function showModal(
component = null,
props = {},
{ backgroundClose= false, escClose= false } = {}
) {
const close = () => popModal()
const modal = await pushModal(component, { onClose: close, ...props })
modal.onclose = (event) => {
let canClose = true
if (event.esc) { canClose = escClose }
if (event.background) { canClose = backgroundClose }
return canClose
}
return modal
} and to use the wrapper in a method: const component = defineAsyncComponent(() => import('../path/to/component'))
showModal(component) // easiest
showModal(component, { prop: 'value' }) // with props (like vue-js-modal)
showModal(component, { prop: 'value', onDone: () => {} }) // supports native Vue events ($emit)
showModal(component, { prop: 'value' }, { backgroundClose: true }) // override backgroundClose and escClose on a per-modal basis |
Anyone still looking for an alternative to |
Here's some reference information. |
Hi,
Do you have plans to support Vue3 ?
Thanks
The text was updated successfully, but these errors were encountered: