#inner_html is choking on self-closing tags within HTML5 elements #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…osing tags within them.
|
Thanks for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/hpricot/hpricot/issues/48
Re: https://github.com/eval/rack-pjax/blob/master/lib/rack/pjax.rb#L24
It appears Hpricot has some issues with HTML5 tags. This can be avoided by using
to_original_htmlinstead ofinner_html.Unfortunately, unlike
inner_html,to_original_htmlreturns the container element as well as the html inside of it so we can't use it directly and instead must iterate over the children.I've attached a pull request (with passing spec) for your perusal.