Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ARGV tests broken with utf8::all 0.013 or later #280

Closed
wants to merge 1 commit into from

Conversation

pghmcfc
Copy link
Contributor

@pghmcfc pghmcfc commented Sep 8, 2014

Addresses #279

Loads utf8::all in the caller to get the desired behaviour.

Addresses evalEmpire#279

Loads utf8::all in the caller to get the desired behaviour.
@schwern
Copy link
Contributor

schwern commented Sep 8, 2014

It failed on 5.14 and earlier. Not sure why. I checked all the tests got the same version of utf8::all.

@schwern
Copy link
Contributor

schwern commented Sep 8, 2014

I dug into a bit using Devel::Peek. @ARGV is being correctly translated, it's the array of expected elements which is not. t/utf8.t is failing as well. This indicates use utf8 is not coming through.

Using Import::Into works, though I'm not sure why. I've been wanting to get rid of our custom code anyway. It doesn't make loading any slower. And I fixed a few bugs along the way (using $class instead of $caller).

@schwern
Copy link
Contributor

schwern commented Sep 8, 2014

I'm going to handle this merge as another pull request on top of your work.

@schwern schwern closed this Sep 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants