The test for finding functions (like timegm()) did not really work.

Unresolved symbols do not always error at compile time, but they appear to do so at link time.
evalEmpire · Feb 16, 2010 · 28a7e8f · 28a7e8f
1 parent c44c16d
commit 28a7e8f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/perl/Time-y2038/Changes b/perl/Time-y2038/Changes
@@ -2,6 +2,8 @@ Next
   Build
   * Switch dependency on JSON::XS to just JSON to eliminate
     Lehmann-ware dependency.
+  * The test for the limits of the time.h did not work for
+    finding functions.
 
 
 20100214.1823_03  Sun Feb 14 18:23:22 PST 2010

diff --git a/perl/Time-y2038/inc/Local/Module/Build.pm b/perl/Time-y2038/inc/Local/Module/Build.pm
@@ -87,9 +87,15 @@ END
         print $fh $code;
         close $fh;
 
-        my $obj = eval { $cb->compile(source => "try.c"); };
-        $self->notes($test, $obj ? 1 : 0);
-        unlink $obj if $obj;
+        my $exe = eval {
+            # Compile AND link to force undefined symbols to error
+            my $obj = $cb->compile(source => "try.c");
+            my $exe = $cb->link_executable(objects => $obj, exe_file => "try");
+            unlink $obj;
+            $exe;
+        };
+        $self->notes($test, $exe ? 1 : 0);
+        unlink $exe if $exe;
         unlink "try.c";
     }
 }