fixing example, cleaning up API, and adding language configuration #8
Conversation
| sonus.mic = {} | ||
| const csr = CloudSpeechRecognizer.init(recognizer) | ||
|
|
||
| opts.hotwords = opts.hotwords || [1] |
There was a problem hiding this comment.
I think it's weird that you default to [1]. What's the deal here?
There was a problem hiding this comment.
Is this because you want to execute adding the default operation? cause there's cleaner ways to do that
There was a problem hiding this comment.
It's a 1 line hack so that if someone passes in a blank config object we'll fallback to adding a single default model. When we iterate over the hotwords (in this case a single item array) it will create one for us.
It's the same as:
if(!opts.hotwords){
models.add({
file: 'node_modules/snowboy/resources/snowboy.umdl',
sensitivity: '0.5',
hotwords : 'default'
})
} else {
opts.hotwords.forEach(model => {
models.add({
file: model.file || 'node_modules/snowboy/resources/snowboy.umdl',
sensitivity: model.sensitivity || '0.5',
hotwords : model.hotword || 'default'
})
})
}We could probably do better error handling here... But let's do that when writing the tests?
| ``` | ||
|
|
||
| Create your own Alexa in less than 10 lines of code: | ||
| Create your own Alexa in less than a tweet: |
| const opts = Object.assign({}, options) | ||
|
|
||
| const sonus = new stream.Writable() | ||
| const opts = Object.assign({}, options), |
There was a problem hiding this comment.
Does object.assign copy nested props?
There was a problem hiding this comment.
Yes.
> let obj = {foo : {bar : 'bash'}, hi : 'mom'}
undefined
> let obj2 = Object.assign({}, obj)
undefined
> console.log(obj2)
{ foo: { bar: 'bash' }, hi: 'mom' }
|
Plenty of things, do while, a small function, even an object literal On Tue, Oct 4, 2016, 10:41 PM Evan Cohen notifications@github.com wrote:
|
|
⛓️ saw |
@ashishsc
Changes:
require('snowboy')