Arecord helper #94
Merged
Arecord helper #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closes issue #68 |
terminate old arecord process when restarting a bit of cleanup use 1.5GB limit
evancohen
force-pushed
the
arecord-helper
branch
from
aa8d6eb
to
edb978c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the age old problem of #68 (alternative solution to #93). Turns out
arecorddoesn't pipe audio after a given file formats max file size. So you can't record indefinitely, which is the whole point of Sonus 😂. This change keeps track of the number of bytes streamed and restarts the recording process silently (hooray).The only downside is that it's not a totally seamless transition from one stream to another. If you're mid-utterance when the change happens, the remainder of the utterance will not be streamed to the cloud detector. But that's better than it stopping completely, so I'll take it 👌