TodoMVC spec fixes #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
|
@evancz D'oh, I was looking at master. Sorry! |
|
No worries, I gave it a silly name! I think the way the trailing spaces are removed is a bit buggy in this PR as it still gets placed in there with extra spaces, but it may be good to bring the approach over from the other branch. Not sure, I'm not really going for spec on the master branch, more about simplicity. |
|
Yeah, I just saw your comment and didn't realize that it was on a different branch when I looked at it later. I'm still seeing a couple of test failures, but let me post that in a separate issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I'm going through some of the test issues. I hope it's okay if I do this iteratively and not in one go.
This addresses how empty new todos are handled, renames
is13toisEnter(which is applicable from the JS code style guidelines we have) and removes some trailing spaces in the code.