-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should this project have a future? #50
Comments
I currently use unzip for a simple web service. It's nice to have it work using streams so I can pipe uploaded files through to disk (using busboy). The input is usually well-formed, so the possible niggles haven't really been a big deal for me. Nor do I think there really are additional features that I wish it had, I just pipe stuff in from one to the other. Anyway, this is more a note of encouragement to say that I do use it! |
I also use it @EvanOxfeld - Not through choice but through adoption, it just caught me out though on the latest node :P |
I use it |
I use it, and I am successful using it to do stuff that fails instead using NodeJS' standard zlib. |
@EvanOxfeld: Thanks for the mention of decompress (I assume you mean https://github.com/bower/decompress-zip, not https://github.com/kevva/decompress). I don't need streaming support, so it fits my needs -- it was surprisingly hard to find. I don't have a stake in the future of this lib, but my 2c is you might try @brianc's approach & just add everyone who has ever made a decent contribution as an owner & see if anyone steps up & helps maintains it. |
I use it in my personal projects, and for the sake of this project it's better to make a stable version asap. |
@EvanOxfeld I'd be happy to do a little bit of maintenance on this project if you make me a collaborator. Merge some pull requests, look at some issues, etc. See my GitHub profile for evidence that I know what I'm doing. |
I use it too. |
Thanks for this project. It is going to be very useful for me and the project I'm working on. I've learned a lot about the zip format and parsing it by looking over your code and then reading up on the spec. Unfortunately it was to debug an issue that I did not realize has been fixed by unzip2. It would be good to either pass this repo onto glebdmitriew of unzip2 or someone else (I'd do it) or simply put a note at the top of the readme recommending people switch to unzip2. |
This module is maintained: https://github.com/thejoshwolfe/yauzl |
true but unfortunately yauzl doesn't support streaming of the source zip file and so is not suitable for a for my projects needs |
@EvanOxfeld I personally need an unzip lib supporting stream because my use case is:
If you do not want/can manage this project, you should add maintainers instead of letting it die (lots of unanswered issues/PRs). Here are some potential candidates:
The more maintainers, the less work for everyone. |
I continue to be floored by the response to this project. While the original implementation was written on a lark, I carried on as a means to better understand streams, arguably the killer feature of NodeJS. Since that time, I've changed companies, ceased personally using this library, and experienced a number of major life events, particularly becoming a father.
I also learned that the zip format is problematic and cannot be perfectly streamed -- see this Apache doc. That said, if despite the major hangups as well as quality non-streaming NodeJS modules, such as decompress, there's continued interest in this project, I'll work to take this project to a stable 1.0.0, merge outstanding pull requests, and most importantly, seek collaborators who use this library in production.
Thank you and let me know your thoughts below.
The text was updated successfully, but these errors were encountered: