Add ifFalse: shortcut

evanphx · Feb 5, 2011 · 3bbcd27 · 3bbcd27
1 parent b54fa11
commit 3bbcd27
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 4 deletions.
diff --git a/lib/prattle/ast/keyword_send.rb b/lib/prattle/ast/keyword_send.rb
@@ -53,13 +53,18 @@ def self.grammar(g)
         end
       end
 
-      def self.conditional(g, name, args)
+      def self.if_cond(g, name, args, if_true)
         return false unless args[0].kind_of? AST::Block
 
         done_lbl = g.new_label
         else_lbl = g.new_label
 
-        g.gif else_lbl
+        if if_true
+          g.gif else_lbl
+        else
+          g.git else_lbl
+        end
+
         args[0].body.each_with_index do |e,idx|
           g.pop unless idx == 0
           e.bytecode(g)
@@ -76,8 +81,11 @@ def self.conditional(g, name, args)
       end
 
       def self.send_method(g, name, args)
-        if name == "ifTrue:"
-          return if conditional g, name, args
+        case name
+        when "ifTrue:"
+          return if if_cond g, name, args, true
+        when "ifFalse:"
+          return if if_cond g, name, args, false
         end
 
         if name[0] == ?~

diff --git a/test/ast/test_keyword_send.rb b/test/ast/test_keyword_send.rb
@@ -236,4 +236,20 @@ def test_shortcut_ifTrue
 
     assert_equal nil, node.run
   end
+
+  def test_shortcut_ifFalse
+    str = '(4 > 3) ifFalse: [ 8 ]'
+
+    parser = Prattle::Parser.new(str)
+    node = parser.parse :keyword_send
+
+    assert_equal nil, node.run
+
+    str = '(3 > 4) ifFalse: [ 8 ]'
+
+    parser = Prattle::Parser.new(str)
+    node = parser.parse :keyword_send
+
+    assert_equal 8, node.run
+  end
 end