Correct hashing of utf8 files

evanpurkhiser · Jul 6, 2015 · d252369 · d252369
1 parent a81b233
commit d252369
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/bin/dots b/bin/dots
@@ -518,8 +518,12 @@ class ConfigFile(object):
 
         # Test that the file hasn't changed
         if os.path.exists(path):
-            installed = hashlib.md5(open(path).read()).digest()
-            compiled  = hashlib.md5(''.join(self.compiled)).digest()
+            compiled = ''.join(self.compiled).encode('utf-8')
+            compiled = hashlib.md5(compiled).digest()
+
+            with open(path, 'r', encoding='utf-8') as installed_file:
+                installed = installed_file.read().encode('utf-8')
+                installed = hashlib.md5(installed).digest()
 
             if installed == compiled and os.stat(path).st_mode == self.mode():
                 return