Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds wiki link to item's image #60

Merged
merged 3 commits into from
Apr 30, 2023

Conversation

dpaskal
Copy link
Contributor

@dpaskal dpaskal commented Apr 18, 2023

This adds a wiki link to items' image/icon in 'Recent items' sections (home page and user page).

Items in the collection log search already have this link so this only adds the link to 'Recent items' sections (On the home page and user page).

Also converted wrapperClassName to const and assign via ternary operator.

This is a feature I've wanted to see added.

Copy link
Owner

@evansloan evansloan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes significantly shrink the size of item images. If you can implement these changes while maintaining the original image size I'll get this merged. Everything else looks good.

Before:
Screenshot 2023-04-19 061139

After:
Screenshot 2023-04-19 061148

@dpaskal
Copy link
Contributor Author

dpaskal commented Apr 22, 2023

Good catch, I didn't notice.

I have applied the fix for this so the icons look identical now.

@dpaskal
Copy link
Contributor Author

dpaskal commented Apr 29, 2023

Is there anything else needed for this PR? @evansloan

@evansloan evansloan merged commit c5d5f15 into evansloan:master Apr 30, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants