Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsconfig.json extends with colliding directory name #2411

Closed
JounQin opened this issue Jul 24, 2022 · 4 comments
Closed

tsconfig.json extends with colliding directory name #2411

JounQin opened this issue Jul 24, 2022 · 4 comments

Comments

@JounQin
Copy link
Author

JounQin commented Jul 24, 2022

Reproduction #2412

@JounQin JounQin changed the title tsconfig.jsonwith extends: resolve file with colliding directory name tsconfig.json extends with colliding directory name Jul 24, 2022
@evanw
Copy link
Owner

evanw commented Jul 24, 2022

You have only posted a link and a single word of text. Please use words to describe what the problem is. Are you saying that esbuild is missing test coverage for this and you just want to add a test? Or are you saying esbuild's behavior in this edge case is incorrect?

@JounQin
Copy link
Author

JounQin commented Jul 24, 2022

OK, when I extends config-package/lib, there is a config-package/lib.json file and also config-package/lib/ directory, lib.json should be preferred. (That's how TypeScript works).

My PR is trying to add a failing test case.

@JounQin
Copy link
Author

JounQin commented Jul 24, 2022

I was going to fix it on my own machine, but I don't understand why whenever I started the test progress, I can never stop it but can restart my machine... So I can not work on a fix for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants