Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(tsconfig): reproduce extends with colliding directory name #2412

Closed
wants to merge 1 commit into from
Closed

test(tsconfig): reproduce extends with colliding directory name #2412

wants to merge 1 commit into from

Conversation

JounQin
Copy link

@JounQin JounQin commented Jul 24, 2022

No description provided.

@evanw
Copy link
Owner

evanw commented Jul 25, 2022

Closing as the underlying issue has been fixed. An end-to-end test is more appropriate than a snapshot test for this since that tests the real file system instead of the mock file system. Testing the real file system is important because Windows does most things differently than POSIX file systems, which typically causes lots of problems unless it has explicit test coverage.

@evanw evanw closed this Jul 25, 2022
@JounQin JounQin deleted the fix/tsconfig branch July 25, 2022 03:47
@JounQin
Copy link
Author

JounQin commented Jul 25, 2022

Thanks for fixing this, I'm not so familiar with the source/test codes. 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants