Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deno module attempts to download npm package from the wrong URL since 0.16.0 #2729

Closed
0f-0b opened this issue Dec 9, 2022 · 2 comments
Closed

Deno module attempts to download npm package from the wrong URL since 0.16.0 #2729

0f-0b opened this issue Dec 9, 2022 · 2 comments

Comments

@0f-0b
Copy link

0f-0b commented Dec 9, 2022

esbuild/lib/deno/mod.ts

Line 70 in 8ef19fe

const url = `https://registry.npmjs.org/${name}/-/${name}-${version}.tgz`

Should be `https://registry.npmjs.org/${name}/-/${name.replace('@esbuild/', '')}-${version}.tgz`.
@boywithkeyboard
Copy link

Same issue here!

@evanw
Copy link
Owner

evanw commented Dec 10, 2022

Whoops, sorry. Will fix.

evanw added a commit that referenced this issue Dec 10, 2022
@evanw
add an end-to-end test for deno (#2729)
a909586
@evanw evanw closed this as completed in 1fb0ee9 Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@evanw @0f-0b @boywithkeyboard