Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Yarn PnP to match the latest specification #2453

Merged
merged 3 commits into from
Aug 10, 2022
Merged

Conversation

evanw
Copy link
Owner

@evanw evanw commented Aug 10, 2022

Changes:

  • Make $$virtual an alias for __virtual__
  • Update testExpectations.json to the latest value
  • Check for platform-specific absolute paths instead of always for the / prefix
  • Ignore PnP manifests in virtual folders

With these changes, Yarn now builds with these instructions:

yarn up esbuild@0.15.0
sed -i.bak -e "s/, pnpPlugin()//" packages/yarnpkg-builder/sources/commands/build/bundle.ts
sed -i.bak -e "s/silent/debug/" packages/yarnpkg-builder/sources/commands/build/bundle.ts
ESBUILD_BINARY_PATH=<path-to-esbuild> yarn build:cli

Fixes #2452

@evanw evanw merged commit 57c8a78 into master Aug 10, 2022
@evanw evanw deleted the yarn-pnp-update branch August 10, 2022 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Virtual paths
1 participant