Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Savings updates #2226
Savings updates #2226
Changes from 16 commits
1075ecd
be5bf4a
5512499
304a8a3
409d52c
23fd099
f9c9a8c
1d31276
fcaa8e8
4f98b9d
8b5129f
70e95df
2bd2ce9
19b4b93
1e92511
dba6e7f
67ad412
e8ef4c5
4235585
d1834d4
51ef8f3
e3683cc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
das muss ein Pointer sein, sonst doppelt sich das mit dem Tariff aus der Config- da schau ich nochmal rein
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
können wir die Zeilen noch in 1 kombinieren? Brauchen wir das jetzt nach der Debugphase überhaupt noch? Weniger Loglines = viel einfachere Fehleranalyse.
Mein Vorschlag: raus, Rest ist im Cache sichtbar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jo, brauchen wir nicht mehr. ist raus.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Die Funktion braucht ein early exit wenn sich nichts geändert hat, z.b. weil wir gar nicht laden. Spart jede Menge log lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ist ein bisschen komplizierter. Nun wird publiziert wenn geladen wird oder sich der Grid-Preis geändert hat.