Skip to content

Commit

Permalink
Add read-only row iterator to Matrix
Browse files Browse the repository at this point in the history
  • Loading branch information
samueltardieu committed Dec 18, 2018
1 parent 91f8e10 commit 98c32bc
Show file tree
Hide file tree
Showing 2 changed files with 58 additions and 0 deletions.
40 changes: 40 additions & 0 deletions src/matrix.rs
Expand Up @@ -380,6 +380,11 @@ impl<C> Matrix<C> {
.filter(move |&(dr, dc)| (diagonals && dr != 0 && dc != 0) || dr.abs() + dc.abs() == 1)
.map(move |(dr, dc)| ((r as isize + dr) as usize, (c as isize + dc) as usize))
}

/// Return an iterator on rows of the matrix.
pub fn iter(&self) -> RowIterator<C> {
(&self).into_iter()
}
}

impl<'a, C> Index<&'a (usize, usize)> for Matrix<C> {
Expand Down Expand Up @@ -458,3 +463,38 @@ impl fmt::Display for MatrixFormatError {
write!(f, "matrix format error: {}", self.message)
}
}

/// Row iterator returned by `iter()` on a matrix.
pub struct RowIterator<'a, C> {
matrix: &'a Matrix<C>,
row: usize,
}

impl<'a, C> Iterator for RowIterator<'a, C> {
type Item = &'a [C];

fn next(&mut self) -> Option<Self::Item> {
if self.row < self.matrix.rows {
let r = Some(
&self.matrix.data
[self.row * self.matrix.columns..(self.row + 1) * self.matrix.columns],
);
self.row += 1;
r
} else {
None
}
}
}

impl<'a, C> IntoIterator for &'a Matrix<C> {
type IntoIter = RowIterator<'a, C>;
type Item = &'a [C];

fn into_iter(self) -> RowIterator<'a, C> {
RowIterator {
matrix: self,
row: 0,
}
}
}
18 changes: 18 additions & 0 deletions tests/matrix.rs
Expand Up @@ -298,3 +298,21 @@ fn from_rows() {
let m = Matrix::from_rows((1..3).map(|n| (1..n).map(move |x| x * n)));
assert!(m.is_err());
}

#[test]
fn iter() {
let m = matrix![[0, 1, 2], [3, 4, 5], [6, 7, 8]];
let mut i = m.iter();
assert_eq!(i.next().unwrap(), &[0, 1, 2]);
assert_eq!(i.next().unwrap(), &[3, 4, 5]);
assert_eq!(i.next().unwrap(), &[6, 7, 8]);
assert_eq!(i.next(), None);
}

#[test]
fn into_iter() {
let m = matrix![[0, 1, 2], [2, 1, 0], [1, 0, 2]];
for c in &m {
assert_eq!(c.iter().sum::<u32>(), 3);
}
}

0 comments on commit 98c32bc

Please sign in to comment.