Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inability to edit, delete (etc.) help topics whose names overlap non-db topic names. #3501

Merged
merged 1 commit into from Apr 27, 2024

Conversation

chiizujin
Copy link
Contributor

Brief overview of PR changes/additions

When database help topics are created with a name that overlaps a non-database help topic, the database topic can no longer be edited in any way, including deletion.

Motivation for adding to Evennia

Bug fix.

Other info

Before:

>sethelp ban = Test.
Warning:
'ban' matches (or partially matches) the key/alias of Command 'ban'.
Command-help take precedence over other help entries so your help *may* be
impossible to reach for those with access to that command.
Do you still want to continue? Y/[N]?
>y
Topic 'ban' was successfully created.
>sethelp/replace ban = Test 2.
Warning:
'ban' matches (or partially matches) the key/alias of Command 'ban'.
Command-help take precedence over other help entries so your help *may* be
impossible to reach for those with access to that command.
Do you still want to continue? Y/[N]?
>y
Error when creating topic 'ban'! Contact an admin.

After:

>sethelp ban = Test.
Warning:
'ban' matches (or partially matches) the key/alias of Command 'ban'.
Command-help take precedence over other help entries so your help *may* be
impossible to reach for those with access to that command.
Do you still want to continue? Y/[N]?
>y
Topic 'ban' was successfully created.
>sethelp/replace ban = Test 2.
Warning:
'ban' matches (or partially matches) the key/alias of Command 'ban'.
Command-help take precedence over other help entries so your help *may* be
impossible to reach for those with access to that command.
Do you still want to continue? Y/[N]?
>y
Overwrote the old topic 'ban'.
>sethelp/edit ban
Warning:
'ban' matches (or partially matches) the key/alias of Command 'ban'.
Command-help take precedence over other help entries so your help *may* be
impossible to reach for those with access to that command.
Do you still want to continue? Y/[N]?
>y
----------Line Editor [topic ban]---------------------------------------------
01| Test 2.
----------[l:01 w:002 c:0007]------------(:h for help)------------------------

Copy link
Member

@Griatch Griatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An edge case, but an annoying one!

@Griatch Griatch merged commit 18a7b9e into evennia:main Apr 27, 2024
7 of 10 checks passed
@chiizujin chiizujin deleted the duplicate_help branch April 28, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants