Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inability to edit, delete (etc.) help topics whose names overlap non-db topic names. #3501

Merged
merged 1 commit into from
Apr 27, 2024
Merged

Fix inability to edit, delete (etc.) help topics whose names overlap non-db topic names. #3501

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 11 additions & 1 deletion evennia/commands/default/help.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -932,7 +932,17 @@ def func(self):
# types of entries.
self.msg(f"|rWarning:\n|r{warning}|n")
repl = yield ("|wDo you still want to continue? Y/[N]?|n")
if repl.lower() not in ("y", "yes"):
if repl.lower() in ("y", "yes"):
# find a db-based help entry if one already exists
db_topics = {**db_help_topics}
db_categories = list(
set(HelpCategory(topic.help_category) for topic in db_topics.values())
)
entries = list(db_topics.values()) + db_categories
match, _ = self.do_search(querystr, entries)
if match:
old_entry = match
else:
self.msg("Aborted.")
return
else:
Expand Down