Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Missing Price Modifiers #1202

Merged
merged 44 commits into from
Jun 29, 2023
Merged

Fix Missing Price Modifiers #1202

merged 44 commits into from
Jun 29, 2023

Conversation

tn3rb
Copy link
Member

@tn3rb tn3rb commented Jun 23, 2023

This PR:

  • fixes https://github.com/eventespresso/cafe/issues/707
  • adds new NoPriceTypesBanner component and displays is TPC detects missing price types
  • refactors Banner & BannerAdapter to simplify structure, types, and styles
  • bunch of other CSS related tweaks

@tn3rb tn3rb self-assigned this Jun 23, 2023
@github-actions github-actions bot added C: assets 💎 category C: data systems 🗑 category C: services 🤝 category C: UI/UX 🚽 category D: EE CORE ☕ domain: Event Espresso Core Plugin D: Packages 📦 domain: Barista Packages labels Jun 23, 2023
@tn3rb tn3rb added T: refactor 🛠 type: MOD - changes in existing functionality D: EDTR ✏️ domain: EE Event Editor P3: med priority 😐 priority: medium D: EE CORE ☕ domain: Event Espresso Core Plugin C: data systems 🗑 category C: assets 💎 category C: services 🤝 category D: Packages 📦 domain: Barista Packages and removed D: EE CORE ☕ domain: Event Espresso Core Plugin C: data systems 🗑 category C: assets 💎 category C: services 🤝 category S4: in progress 🚧 status D: Packages 📦 domain: Barista Packages C: UI/UX 🚽 category labels Jun 23, 2023
@tn3rb tn3rb requested a review from alexkuc June 23, 2023 23:34
@tn3rb tn3rb force-pushed the FIX/missing-price-modifiers branch from 79cb483 to 7bcd846 Compare June 26, 2023 16:53
@github-actions github-actions bot added C: UI/UX 🚽 category and removed D: EDTR ✏️ domain: EE Event Editor labels Jun 26, 2023
@tn3rb tn3rb force-pushed the FIX/missing-price-modifiers branch from 7bcd846 to 82c67fa Compare June 26, 2023 23:07
alexkuc
alexkuc requested changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@alexkuc alexkuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments in the code. Please let me know. Thanks.

packages/services/src/utils/getAdminUrl.ts Show resolved Hide resolved
packages/tpc/src/buttons/AddPriceModifierButtonData.tsx Show resolved Hide resolved
packages/tpc/src/components/NoPricesBanner.tsx Show resolved Hide resolved
packages/tpc/src/components/PricingAdminLink.tsx Show resolved Hide resolved
packages/tpc/src/components/TicketPriceCalculator.tsx Show resolved Hide resolved
packages/tpc/src/components/TicketPriceCalculator.tsx Outdated Show resolved Hide resolved
packages/ui-components/src/Banner/Banner.tsx Outdated Show resolved Hide resolved
packages/ui-components/src/EmptyState/EmptyState.tsx Show resolved Hide resolved
@tn3rb tn3rb force-pushed the FIX/missing-price-modifiers branch from 8727808 to 7749579 Compare June 29, 2023 17:11
alexkuc
alexkuc requested changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@alexkuc alexkuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 1 more thing I noticed with AddPriceModifierButtonData.tsx. Everything else looks super great 😎 !

packages/tpc/src/buttons/AddPriceModifierButtonData.tsx Show resolved Hide resolved
alexkuc
alexkuc previously approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@alexkuc alexkuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😎 🚀

alexkuc
alexkuc approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@alexkuc alexkuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😎 🚀

@tn3rb tn3rb merged commit 8f28b95 into master Jun 29, 2023
8 checks passed
@tn3rb tn3rb deleted the FIX/missing-price-modifiers branch June 29, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexkuc alexkuc alexkuc approved these changes

Assignees

@tn3rb tn3rb

Labels
C: assets 💎 category C: data systems 🗑 category C: services 🤝 category C: UI/UX 🚽 category D: EE CORE ☕ domain: Event Espresso Core Plugin D: Packages 📦 domain: Barista Packages P3: med priority 😐 priority: medium S11: completed 🚀 status T: refactor 🛠 type: MOD - changes in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tn3rb @alexkuc @eeteamcodebase