EDTR: TypeScript support. #1838

nicolad · 2019-11-12T14:32:37Z

Implements this issue: #1836

tn3rb

beautiful! love it!

think there's one output config line that looks like it still needs deleting.
going to approve now assuming the above will be fixed

tn3rb · 2019-11-12T15:15:43Z

config/webpack.common.js

@@ -138,7 +124,6 @@ const config = [
 		module: moduleConfigWithJsRules,
 		output: {
 			filename: '[name].[chunkhash].dist.js',


should this be removed too?

Yes, absolutely, thx.

mnelson4 · 2019-11-12T17:47:20Z

Just heard of TypeScript today, and it sounds like our jam. But let's not forget to document these changes both for our own reference (including the client-side Ludites like me who think we're basically moving back to client-side Java applets), and also for 3rd party devs who may not be familiar with TypeScript or our usage of it.

We don't need to give a tutorial on TypeScript of course, but IMO we should state why we're using it, give some links to docs on how to learn more, and make sure someone who's new to TypeScript can still setup EE from source and run it locally.

nicolad · 2019-11-12T17:50:11Z

Just heard of TypeScript today, and it sounds like our jam. But let's not forget to document these changes both for our own reference (including the client-side Ludites like me who think we're basically moving back to client-side Java applets), and also for 3rd party devs who may not be familiar with TypeScript or our usage of it.

We don't need to give a tutorial on TypeScript of course, but IMO we should state why we're using it, give some links to docs on how to learn more, and make sure someone who's new to TypeScript can still setup EE from source and run it locally.

Sure, is this location appropriate for this purpose: https://github.com/eventespresso/event-espresso-core/tree/master/docs/AA--Javascript-in-EE ?

tn3rb · 2019-11-12T18:04:33Z

assets/src/components/ui/drop-down-menu/index.tsx

@@ -21,7 +23,7 @@ const DropDownMenu = ( {
 	tooltipPosition = 'top left',
 	index = 0,
 	...otherProps
-} ) => {
+} : PropTypes.InferProps<typeof DropDownMenu.propTypes> ) => {


this is going to conflict with my branch that changes the folder structure...
although I might have to rework that branch to avoid having a gazillion broken unit tests { : \

Not a problem.
the power of sublime merge will help me 🛠️

@tn3rb I had reverted this change since it was causing tests failure and orchestrating all the stuff to handle tsx for jest needs to be done in a separate PR.

The only thing left for now in this PR is docs, as suggested by @mnelson4

mnelson4 · 2019-11-12T18:32:03Z

Sure, is this location appropriate for this purpose: /docs/AA--Javascript-in-EE@master ?

🤘 Yeah I think somewhere in there. But I'm not sure if it's best to add a new file, or new folder of files, or just update existing files. I suppose it kinda depends on the nature of the changes.

tn3rb

awesome!

think there's one spot that's still referencing the bin folder that needs to be updated

tn3rb · 2019-11-13T15:10:43Z

config/webpack.common.js

+const enhancedConfig = config
+	.map( enhance )
+	.map( addLoaders );


very nice 👍

tn3rb · 2019-11-13T15:11:55Z

config/webpack.prod.js

 const common = require( './webpack.common.js' );
 const webpack = require( 'webpack' );
 const miniExtract = require( 'mini-css-extract-plugin' );
-const wpi18nExtractor = require( './bin/i18n-map-extractor.js' );
+const wpi18nExtractor = require( '../bin/i18n-map-extractor.js' );


bin folder got renamed no?

Not yet, I moved only asset-dependency-maps.js from ./bin directory for now, because this file was related to webpack configs.
Didn't wanted to pollute PR's diff with too many changes.
If you want, I can move the other files and references from ./bin to ./config

ahh ok, what you have done is fine.

Ideally we should move all config files into the new config folder you created, but that can happen in another PR.
I don't understand why that bin folder was created considering it does not contain any binary files !?!?

Maybe bin from trash bin/can 🤔

tn3rb · 2019-11-13T15:21:25Z

docs/AA--Javascript-in-EE/typescript.md

+## Static type checking with `TypeScript`.
+
+TypeScript compilation is integrated into build process via webpack, through TS loaders. This means that we don't have to run any additional scripts. By running usual webpack-related scripts all TS compilation will be done automatically.
+
+Since we already have some codebase written in JS, in `tsconfig.json` the option `allowJs` has been set to `true`. This will enable us to make an incremental adoption of TypeScript.
+
+Related external reading:
+
+- [React & Webpack](https://www.typescriptlang.org/docs/handbook/react-&-webpack.html)
+- [Migrating from JavaScript](https://www.typescriptlang.org/docs/handbook/migrating-from-javascript.html)


good stuff 💯

nicolad · 2019-11-13T17:17:04Z

config/paths.js

+const ASSETS = 'assets';
+
+const assetsManifestOutputPath = path.resolve( ASSETS, 'dist/build-manifest.json' );
+const assetsPath = `./${ ASSETS }/ZZZ/`;


Added const here for consistency, but I am not 💯 happy with how readability ended :)

oh ha ha ya we don't want to keep that as all of the new EDTR replacement files will still be in /assets/src/
the ZZZ folder was just a way to keep all of the existing logic untouched and out of the way while we refactor everything

nicolad requested review from tn3rb and manzoorwanijk November 12, 2019 14:32

nicolad self-assigned this Nov 12, 2019

nicolad added this to In progress in EDTR Conversion to Apollo GraphQL. branch: EDTR/master via automation Nov 12, 2019

enhanced-triage-bot bot added the status:triage label Nov 12, 2019

nicolad added type: tooling 🔨 and removed status:triage labels Nov 12, 2019

tn3rb previously approved these changes Nov 12, 2019

View reviewed changes

EDTR Conversion to Apollo GraphQL. branch: EDTR/master automation moved this from In progress to Reviewer approved Nov 12, 2019

nicolad dismissed tn3rb’s stale review via b05658a November 12, 2019 15:25

EDTR Conversion to Apollo GraphQL. branch: EDTR/master automation moved this from Reviewer approved to Review in progress Nov 12, 2019

nicolad marked this pull request as ready for review November 12, 2019 16:52

nicolad assigned tn3rb and manzoorwanijk Nov 12, 2019

tn3rb self-requested a review November 12, 2019 17:14

tn3rb previously approved these changes Nov 12, 2019

View reviewed changes

EDTR Conversion to Apollo GraphQL. branch: EDTR/master automation moved this from Review in progress to Reviewer approved Nov 12, 2019

nicolad dismissed tn3rb’s stale review via 5d579f2 November 12, 2019 19:14

EDTR Conversion to Apollo GraphQL. branch: EDTR/master automation moved this from Reviewer approved to Review in progress Nov 12, 2019

nicolad force-pushed the EDTR/ts branch 2 times, most recently from eea5a5f to 780f060 Compare November 13, 2019 08:38

nicolad requested a review from tn3rb November 13, 2019 11:10

nicolad mentioned this pull request Nov 13, 2019

Jest + TS configuration #1842

Closed

nicolad force-pushed the EDTR/ts branch 2 times, most recently from 0d0fdb1 to fef3704 Compare November 13, 2019 12:42

tn3rb requested changes Nov 13, 2019

View reviewed changes

tn3rb self-requested a review November 13, 2019 15:35

manzoorwanijk previously approved these changes Nov 13, 2019

View reviewed changes

EDTR Conversion to Apollo GraphQL. branch: EDTR/master automation moved this from Review in progress to Reviewer approved Nov 13, 2019

nicolad added 14 commits November 13, 2019 19:04

Moved configs to a separate folder.

3cb90bb

Conflicts fixed.

5bc4835

Conflicts fixed.

763e8ac

Added loaders and preloaders.

72b5285

Oops, missed one.

18c1fc0

Added jsx flag.

ebf12df

Updated webpack location.

3614e68

Converted DropDownMenu to .tsx

6c804f7

Updated webpack config.

82652e3

Added centralized paths.

d4f175b

Small improvements.

4b6191c

Updated wpi18nExtractor path.

eb45710

Conflicts fixed.

710b562

Reverted change in DropDownMenu.

af7b7bf

nicolad dismissed manzoorwanijk’s stale review via af7b7bf November 13, 2019 17:08

nicolad force-pushed the EDTR/ts branch from b6ec0f0 to af7b7bf Compare November 13, 2019 17:08

EDTR Conversion to Apollo GraphQL. branch: EDTR/master automation moved this from Reviewer approved to Review in progress Nov 13, 2019

nicolad added 2 commits November 13, 2019 19:09

Reverted change in DropDownMenu.

1936257

Extracted assets path.

5c34273

nicolad requested review from tn3rb and manzoorwanijk November 13, 2019 17:14

nicolad commented Nov 13, 2019

View reviewed changes

tn3rb approved these changes Nov 13, 2019

View reviewed changes

EDTR Conversion to Apollo GraphQL. branch: EDTR/master automation moved this from Review in progress to Reviewer approved Nov 13, 2019

nicolad merged commit 980996c into EDTR/master Nov 13, 2019

EDTR Conversion to Apollo GraphQL. branch: EDTR/master automation moved this from Reviewer approved to Done Nov 13, 2019

nicolad deleted the EDTR/ts branch November 13, 2019 17:50

manzoorwanijk removed their assignment Nov 14, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

EDTR: TypeScript support. #1838

EDTR: TypeScript support. #1838

nicolad commented Nov 12, 2019

tn3rb left a comment

tn3rb Nov 12, 2019

nicolad Nov 12, 2019

mnelson4 commented Nov 12, 2019

nicolad commented Nov 12, 2019

tn3rb Nov 12, 2019

nicolad Nov 12, 2019

nicolad Nov 12, 2019

mnelson4 commented Nov 12, 2019 •

edited

tn3rb left a comment

tn3rb Nov 13, 2019

tn3rb Nov 13, 2019

nicolad Nov 13, 2019 •

edited

tn3rb Nov 13, 2019

nicolad Nov 13, 2019

tn3rb Nov 13, 2019

manzoorwanijk Nov 13, 2019

nicolad Nov 13, 2019

tn3rb Nov 13, 2019

EDTR: TypeScript support. #1838

EDTR: TypeScript support. #1838

Conversation

nicolad commented Nov 12, 2019

tn3rb left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mnelson4 commented Nov 12, 2019

nicolad commented Nov 12, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mnelson4 commented Nov 12, 2019 • edited

tn3rb left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nicolad Nov 13, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mnelson4 commented Nov 12, 2019 •

edited

nicolad Nov 13, 2019 •

edited