Extract Attendee Info Reg Form Processing into New Classes #3419

tn3rb · 2021-06-03T18:34:01Z

This PR:

extracts logic from EE_SPCO_Reg_Step_Attendee_Information::process_reg_step() into the following new classes:
- RegFormHandler
- RegFormInputHandler
- RegFormAttendeeFactory
- RegistrantData
extracts a bit more logic from the RegForm into PrivacyConsentCheckboxForm
extracts most of the dependency registration from EE_Dependency_Map into RegFormDependencyHandler
refactors a few other form related things after the above changes
cleans up a few other things

manzoorwanijk · 2021-06-04T06:35:59Z

core/EE_Dependency_Map.core.php

-            'EventEspresso\core\domain\services\registration\form\v1\RegForm' => [
-                null,
-                'EE_Registration_Config' => EE_Dependency_Map::load_from_cache,
-            ],
-            'EventEspresso\core\domain\services\registration\form\v1\RegistrationForm' => [
-                null,
-                null,
-                null,
-                null,
-                'EEM_Event_Question_Group' => EE_Dependency_Map::load_from_cache,
-            ],
-            'EventEspresso\core\domain\services\registration\form\v1\QuestionGroupRegForm' => [
-                null,
-                null,
-                null,
-                'EventEspresso\core\domain\services\registration\form\v1\RegFormQuestionFactory' => EE_Dependency_Map::load_from_cache,
-            ],
-            'EventEspresso\core\domain\services\registration\form\v1\CountryOptions' => [
-                null,
-                'EEM_Answer' => EE_Dependency_Map::load_from_cache,
-                'EEM_Country' => EE_Dependency_Map::load_from_cache,
-            ],
-            'EventEspresso\core\domain\services\registration\form\v1\StateOptions' => [
-                null,
-                'EEM_State' => EE_Dependency_Map::load_from_cache,
+            'EventEspresso\core\domain\services\registration\form\v1\RegFormDependencyHandler' => [
+                'EE_Dependency_Map' => EE_Dependency_Map::load_from_cache,


manzoorwanijk · 2021-06-04T06:37:12Z

core/domain/services/registration/form/v1/RegFormHandler.php

+        $reg_form = $this->checkout->current_step->reg_form;
+        $required_questions = $reg_form instanceof RegForm ? $reg_form->requiredQuestions() : [];
+        $this->input_handler = LoaderFactory::getShared(
+            RegFormInputHandler::class,


Now you like ::class 😄

manzoorwanijk · 2021-06-04T06:39:28Z

core/domain/services/registration/form/v1/RegFormHandler.php

+            $copy_primary = isset($reg_form_data[ $reg_url_link ]['additional_attendee_reg_info'])
+                                  && absint($reg_form_data[ $reg_url_link ]['additional_attendee_reg_info']) === 0;


Why not simply this?

Suggested change

$copy_primary = isset($reg_form_data[ $reg_url_link ]['additional_attendee_reg_info'])

&& absint($reg_form_data[ $reg_url_link ]['additional_attendee_reg_info']) === 0;

$copy_primary = empty($reg_form_data[ $reg_url_link ]['additional_attendee_reg_info']);

i'm guessing (since that code was probably originally written close to a decade ago) that additional_attendee_reg_info might hold value with different data types... like bool, int, string so running absint() on a string value (and then comparing against 0) is very different than just using empty().

what you've suggested might very well work fine, but i'm really hesitant to modify the logic in older code if I don't have to because there may be some weird edge case that some seemingly unnecessary line of code is accounting for. I've tried really hard to keep things operating exactly the same throughout this refactor because I don't want the existing code to get broken :\

manzoorwanijk

Looks great 🚀

knazart

👍

tn3rb added 14 commits June 3, 2021 11:21

renamespace class and extract for SRP

9d8c845

fix formatting

73517a0

extract logic into new RegFormHandler class

886e341

register deps and fix passed args

21a9fb6

refactor/rename forms

65c3bb6

extracted logic into new class

45d24cc

DependencyHandler for RegForm

ba1770a

renamed/refactored form

22e0de0

DTO for tracking & sharing data during reg process

937d6c0

inject model, fix RequiredQuestions

c542af0

extract reg form processing into new classes

a0e9e9b

phpdoc formatting

16b8604

fix missing dependency

eb38191

add/extract dependency registration

10abe78

tn3rb added type:enhancement 🎉 category:spco-&-registration status:review labels Jun 3, 2021

tn3rb requested review from knazart and manzoorwanijk June 3, 2021 18:34

tn3rb self-assigned this Jun 3, 2021

tn3rb added 3 commits June 3, 2021 11:38

remove unused import

e3bc85a

fix formatting

605c239

remove unused method

6e8a58b

manzoorwanijk reviewed Jun 4, 2021

View reviewed changes

manzoorwanijk approved these changes Jun 4, 2021

View reviewed changes

knazart approved these changes Jun 4, 2021

View reviewed changes

tn3rb added a commit that referenced this pull request Jun 28, 2021

Extract Attendee Info Reg Form Processing into New Classes (#3419)

a1a09a8

tn3rb added a commit that referenced this pull request Jun 28, 2021

Extract Attendee Info Reg Form Processing into New Classes (#3419)

04d2013

tn3rb added a commit that referenced this pull request Jun 28, 2021

Extract Attendee Info Reg Form Processing into New Classes (#3419)

e5903f7

tn3rb added a commit that referenced this pull request Jun 28, 2021

Extract Attendee Info Reg Form Processing into New Classes (#3419)

d028434

tn3rb added a commit that referenced this pull request Jul 1, 2021

Extract Attendee Info Reg Form Processing into New Classes (#3419)

6e5fabf

tn3rb added a commit that referenced this pull request Jul 2, 2021

Extract Attendee Info Reg Form Processing into New Classes (#3419)

8013573

tn3rb added a commit that referenced this pull request Jul 5, 2021

Extract Attendee Info Reg Form Processing into New Classes (#3419)

a3d0d05

tn3rb added a commit that referenced this pull request Jul 6, 2021

Extract Attendee Info Reg Form Processing into New Classes (#3419)

2fc0cc1

tn3rb added a commit that referenced this pull request Jul 7, 2021

Extract Attendee Info Reg Form Processing into New Classes (#3419)

47a374d

tn3rb added a commit that referenced this pull request Jul 8, 2021

Extract Attendee Info Reg Form Processing into New Classes (#3419)

2e06dcf

tn3rb added a commit that referenced this pull request Jul 21, 2021

Extract Attendee Info Reg Form Processing into New Classes (#3419)

3a3f77a

tn3rb added a commit that referenced this pull request Jul 26, 2021

Extract Attendee Info Reg Form Processing into New Classes (#3419)

a01d6b3

tn3rb added a commit that referenced this pull request Jul 26, 2021

Extract Attendee Info Reg Form Processing into New Classes (#3419)

c156829

tn3rb added a commit that referenced this pull request Jul 27, 2021

Extract Attendee Info Reg Form Processing into New Classes (#3419)

3618d32

tn3rb added a commit that referenced this pull request Jul 29, 2021

Extract Attendee Info Reg Form Processing into New Classes (#3419)

ee6f8e6

tn3rb added a commit that referenced this pull request Jul 30, 2021

Extract Attendee Info Reg Form Processing into New Classes (#3419)

af5f455

tn3rb added a commit that referenced this pull request Aug 19, 2021

Extract Attendee Info Reg Form Processing into New Classes (#3419)

622c683

tn3rb added a commit that referenced this pull request Aug 19, 2021

Extract Attendee Info Reg Form Processing into New Classes (#3419)

3de0fc4

tn3rb added a commit that referenced this pull request Aug 30, 2021

Extract Attendee Info Reg Form Processing into New Classes (#3419)

253ead9

tn3rb added a commit that referenced this pull request Sep 10, 2021

Extract Attendee Info Reg Form Processing into New Classes (#3419)

fb296ce

tn3rb added a commit that referenced this pull request Sep 13, 2021

Extract Attendee Info Reg Form Processing into New Classes (#3419)

765d336

tn3rb added a commit that referenced this pull request Sep 14, 2021

Extract Attendee Info Reg Form Processing into New Classes (#3419)

3c00e6b

tn3rb added a commit that referenced this pull request Sep 15, 2021

Extract Attendee Info Reg Form Processing into New Classes (#3419)

7750ea0

tn3rb added a commit that referenced this pull request Sep 17, 2021

Extract Attendee Info Reg Form Processing into New Classes (#3419)

5519bf5

tn3rb added a commit that referenced this pull request Sep 20, 2021

Extract Attendee Info Reg Form Processing into New Classes (#3419)

5502d63

tn3rb added a commit that referenced this pull request Sep 21, 2021

Extract Attendee Info Reg Form Processing into New Classes (#3419)

bc5b333

tn3rb added a commit that referenced this pull request Sep 21, 2021

Extract Attendee Info Reg Form Processing into New Classes (#3419)

e6a3211

tn3rb added a commit that referenced this pull request Sep 23, 2021

Extract Attendee Info Reg Form Processing into New Classes (#3419)

126bc8b

tn3rb added a commit that referenced this pull request Sep 28, 2021

Extract Attendee Info Reg Form Processing into New Classes (#3419)

8962daa

tn3rb added a commit that referenced this pull request Sep 29, 2021

Extract Attendee Info Reg Form Processing into New Classes (#3419)

4b7c24f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extract Attendee Info Reg Form Processing into New Classes #3419

Extract Attendee Info Reg Form Processing into New Classes #3419

tn3rb commented Jun 3, 2021

manzoorwanijk Jun 4, 2021

manzoorwanijk Jun 4, 2021

manzoorwanijk Jun 4, 2021

tn3rb Jun 4, 2021

manzoorwanijk left a comment

knazart left a comment

		$copy_primary = isset($reg_form_data[ $reg_url_link ]['additional_attendee_reg_info'])
		&& absint($reg_form_data[ $reg_url_link ]['additional_attendee_reg_info']) === 0;

	$copy_primary = isset($reg_form_data[ $reg_url_link ]['additional_attendee_reg_info'])
	&& absint($reg_form_data[ $reg_url_link ]['additional_attendee_reg_info']) === 0;
	$copy_primary = empty($reg_form_data[ $reg_url_link ]['additional_attendee_reg_info']);

Extract Attendee Info Reg Form Processing into New Classes #3419

Extract Attendee Info Reg Form Processing into New Classes #3419

Conversation

tn3rb commented Jun 3, 2021

manzoorwanijk Jun 4, 2021

Choose a reason for hiding this comment

manzoorwanijk Jun 4, 2021

Choose a reason for hiding this comment

manzoorwanijk Jun 4, 2021

Choose a reason for hiding this comment

tn3rb Jun 4, 2021

Choose a reason for hiding this comment

manzoorwanijk left a comment

Choose a reason for hiding this comment

knazart left a comment

Choose a reason for hiding this comment