Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show scrollbars #7

Closed
johnjohndoe opened this issue Sep 2, 2017 · 4 comments · Fixed by #434
Closed

Show scrollbars #7

johnjohndoe opened this issue Sep 2, 2017 · 4 comments · Fixed by #434
Assignees
@isiko
Labels
Bug report Supposed to be assigned to issues. Favorites The favorites screen, starring a session Hacktoberfest Query your favorite search engine for "Hacktoberfest". Help wanted You are invited to help. Please annouce it as a comment on the issue. Schedule changes Schedule changes dialog, schedule changes screen Scrolling UI interaction in list and grid views UX User experience, accessibility, screen readers, touch feedback, ...
Milestone
v.1.53.1

Comments

@johnjohndoe
Copy link
Member

johnjohndoe commented Sep 2, 2017 •
edited
Loading

The different views (details, favorites, changes*) are scrollable but do not show scrollbars when users scroll. The alarms screen shows scrollbars.

*not verified yet.
@johnjohndoe johnjohndoe added Bug report Supposed to be assigned to issues. UX User experience, accessibility, screen readers, touch feedback, ... labels Sep 2, 2017
@johnjohndoe johnjohndoe added the Help wanted You are invited to help. Please annouce it as a comment on the issue. label Dec 21, 2018
@johnjohndoe johnjohndoe added the Hacktoberfest Query your favorite search engine for "Hacktoberfest". label Sep 26, 2019
@johnjohndoe johnjohndoe added the Scrolling UI interaction in list and grid views label Jan 12, 2021
@isiko
Copy link
Contributor

isiko commented Dec 29, 2021

I would like to try and fix this

@johnjohndoe
Copy link
Member Author

johnjohndoe commented Dec 29, 2021 •
edited
Loading

Great. Please re-evaluate which screens are affected in the current version on master since this issue is rather old. Please reach out if you like to discuss your approach.

@isiko
Copy link
Contributor

isiko commented Dec 29, 2021

I already fixed the Favorites page by removing some margins and paddings that had pushed the ScrollBar off the screen (I couldn't see any difference in the layout after removing them, so I figured they wouldn't do anything important)

I'm working on the details layout now, I'm just getting into the structure.

@isiko
Copy link
Contributor

isiko commented Dec 30, 2021

Update:
The Details Screen already shows a Scrollbar.
Also, the change list looks like it has the same problem as the favorites page (the layout extends beyond the edge of the screen on both pages), but unfortunately since there are no changes I can't verify that

@isiko isiko mentioned this issue Dec 30, 2021
Merged
johnjohndoe pushed a commit to isiko/EventFahrplan that referenced this issue Jan 3, 2022
@isiko @johnjohndoe
Fix scrollbars for favorites and changes screens on phones.
ecd836a 
+ Removed some margins as they push the edges of the layout
  (and thus the scrollbar) off the screen

Resolves EventFahrplan#7
@johnjohndoe johnjohndoe added Favorites The favorites screen, starring a session Schedule changes Schedule changes dialog, schedule changes screen labels Jan 3, 2022
@johnjohndoe johnjohndoe added this to the v.1.53.1 milestone Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@isiko isiko

Labels
Bug report Supposed to be assigned to issues. Favorites The favorites screen, starring a session Hacktoberfest Query your favorite search engine for "Hacktoberfest". Help wanted You are invited to help. Please annouce it as a comment on the issue. Schedule changes Schedule changes dialog, schedule changes screen Scrolling UI interaction in list and grid views UX User experience, accessibility, screen readers, touch feedback, ...
Milestone
v.1.53.1
Development

Successfully merging a pull request may close this issue.

Fix display errors in the favorites scroll bar and the change screen isiko/EventFahrplan
2 participants
@johnjohndoe @isiko