.Net core 3 support #686
.Net core 3 support #686
Conversation
|
|
|
@rasmus I think build is blocked by some variables set on your AppVeyor account (relative to SQL Server). |
|
Any updates on this? I am soooo soooo waiting for this merge |
I can't do anything... Build is working fine on my appveyor account. @rasmus we need you! |
| IConfigureOptions<MvcJsonOptions> | ||
| #endif | ||
| #if NETCOREAPP3_0 | ||
| IConfigureOptions<MvcNewtonsoftJsonOptions> |
There was a problem hiding this comment.
I think that using ASP.NET Core 2.1 on .NET Core is possible. This scenario will fail, won't it?
waiting for eventflow merge below request:eventflow/EventFlow#686
|
Hi @ProH4Ck thanks for the PR, but it seems like the integration tests for MSSQL and EF are broken though. 👍 for moving the integration test setup to the official images! |
Hi @rasmus I have no variables set in my account:
I tried to move sql server to docker but memory limits on appveyor prevent container to start... |
|
Dotnet core 2.2 is reaching its end of life by the end of this year. |
|
@Brandon2255p I'm going through the settings and everything seems to be as should be. My wife has started evening school which means I don't have as much time for spare time projects as I would like, as I have the kids full time. I do try to keep up, but I'll try to be more available. |
|
I'll see if I can do a separate update of the image to 2019 tonight, removing the need for it in this PR. |
|
I'll try to get the image change working in #709 |
|
Found the problem in #709, will hopefully get it merged tonight. If it does, I'll merge develop into this PR as well to see if fixes the build here as well. |
Hooray! |
|
Amazing! Thanks so much. Really appreciate that you made the time
…On Mon, 09 Dec 2019, 21:18 Mario Adam, ***@***.***> wrote:
Found the problem in #709
<#709>, will hopefully get it
merged tonight. If it does, I'll merge develop into this PR as well to see
if fixes the build here as well.
Hooray!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#686?email_source=notifications&email_token=ACDO5LHCCMSQTDHK7RKCZDLQX2KZ5A5CNFSM4I2KVNQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGKKQBQ#issuecomment-563390470>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACDO5LAUYBIZP3VYX2U5ZUTQX2KZ5ANCNFSM4I2KVNQA>
.
|
|
@Brandon2255p just keep poking me if I don't respond. Its my responsibility and I need to make the time. There's a problem with the license in several of the source files (not from this PR). Basically the header isn't correct in accordance to the CLA. I'm correcting this in #712 and will release as soon as its done. I try to keep the legal stuff correct, but darn its hard. |
|
Finally merged! Thanks! |
|
@rasmus awesome! Thanks for the great work! Is there already a new NuGet release for this? |
|
Yes, as soon as I get out of bed, had to leave work due to sickness. I hope to do it within the next few hours.
… On 10 Dec 2019, at 15.38, Michel van den Berg ***@***.***> wrote:
@rasmus awesome! Thanks for the great work! Is there already a new NuGet release for this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
@rasmus take your time :) no need to rush |
|
@promontis managed to get out of bed and start the release. You can follow it here https://ci.appveyor.com/project/eventflow/eventflow/builds/29444767 I'll check on it in a few hours to see if everything is ok. The GitHub release draft with artifacts needs to be published manually, but the NuGet packages will be uploaded during the build. As soon as NuGet then indexes the packages, you should be able to upgrade. |
|
It's up \o/ \o/ \o/ |
This let it works with a .net core 3 project and solves:
System.TypeLoadException: 'Could not load type 'Microsoft.AspNetCore.Mvc.MvcJsonOptions' from assembly 'Microsoft.AspNetCore.Mvc.Formatters.Json, Version=3.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60'.'