-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ssl: context wrapped listener failed to supply _context in accept() #655
Conversation
03e2115
to
95037ee
Compare
Last version fails on Python 2.7 - 3.6, works on 3.7+. I'm tired today, will continue later. Error with keyfile argument.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me on Python 3.8.5 and looks reasonable.
Works now. |
Codecov Report
@@ Coverage Diff @@
## master #655 +/- ##
======================================
Coverage 44% 44%
======================================
Files 87 87
Lines 11841 11841
Branches 1777 1778 +1
======================================
+ Hits 5278 5279 +1
+ Misses 6167 6166 -1
Partials 396 396
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
How does the code work on Python older than 3.8 with |
Sorry, it's a working black magic for me, currently. Test passes, so apparently they are read from context. So I was wondering is it redundant to pass them at all. And can you believe it, all key/cert related kwargs were redundant. It passes py2.7 and 3.7 without extra 3.7 condition. Hope it will pass all tests. Thank you. |
@jstasiak and for shorter diff too, I've only noticed it too late after push, was too much excited about dropping cert/key kwargs. Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it was just a detail, LGTM regardless.
#651
Seems correct, but could potentially break a lot of code, so calling for extensive public testing.
pip install -U https://github.com/eventlet/eventlet/archive/i651.zip
and try to run your software.