-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
patcher: [py27] recursion error in pytest/python2.7 installing register_at_fork #661
Conversation
Guys I tried to create test, was hoping for trigger if os/threading was previously imported or double execute anything, but no luck. Maybe pytest does something wonderful. Can't put too much time into this. But I need working python-sentry :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one comment.
eventlet/patcher.py
Outdated
@@ -229,7 +231,6 @@ def monkey_patch(**on): | |||
|
|||
It's safe to call monkey_patch multiple times. | |||
""" | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This removal (and and #_os = original('os')
line above) would be better left out of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it even broke pep8 checker. Sorry, wasn't careful after trying random stuff with testing.
699c48b
to
0a5eee2
Compare
Codecov Report
@@ Coverage Diff @@
## master #661 +/- ##
======================================
Coverage 44% 44%
======================================
Files 87 87
Lines 11843 11848 +5
Branches 1779 1779
======================================
+ Hits 5276 5280 +4
- Misses 6165 6166 +1
Partials 402 402
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
9f4c3d6
to
55b0698
Compare
…er_at_fork #660 getsentry/sentry-python#880 Could not reproduce problem without pytest, so normal production code was probably safe.
55b0698
to
7a8c83d
Compare
#660
getsentry/sentry-python#880
Could not reproduce problem without pytest, so normal production code was probably safe.