Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code to remove newline in smtpclient.rb : invoke_auth #361

Closed
joastbg opened this issue Aug 31, 2012 · 1 comment
Closed

Add code to remove newline in smtpclient.rb : invoke_auth #361

joastbg opened this issue Aug 31, 2012 · 1 comment

Comments

@joastbg
Copy link

joastbg commented Aug 31, 2012

Some username/password combinations will make a new line in the auth string, row 56 smtpclient.rb.

Simple fix:
str = ["\0#{@Args[:auth][:username]}\0#{psw}"].pack("m").chomp.gsub("\n","")

As it is now a error will come from some servers, because the newline in the auth-string:
501 Syntax error at character position 71. CR and LF must be CRLF paired. See RFC 2821 #2.7.1.

@tmm1
Copy link
Contributor

tmm1 commented Feb 28, 2013

Fixed in #364

@tmm1 tmm1 closed this as completed Feb 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants