Make PLAIN AUTH SMTP work with long username/passwords. #364
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it stands, the smtpclient protocol uses Array#pack to base64 encode data, which wraps the output at 60-characters (as you would when sending base64-encoded mail). However, the AUTH SMTP extension expects the initial authentication string to be a single line.
This is a particular issue when using credentials for Amazon's simple email service, which tend to be quite long (>64 characters combined).
Is this okay to be merged as is, or is there anything else you'd need me to do first?