Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to enable to work an example code in EM::Pool #731

Merged
merged 2 commits into from Aug 29, 2016

Conversation

taise
Copy link

@taise taise commented Aug 29, 2016

I fixed an example code in EventMachine::Pool

  • It was expected to request 100.times, but it was only one requested
  • Exception: undefined local variable or method i

@@ -1,41 +1,41 @@
module EventMachine
# = EventMachine::Pool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need to keep this line for the documentation to generate?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for checking.
It seems style of Rdoc.
When I executed bundle exec rake yard, doc/EventMachine/Pool.html was generated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! Thanks for checking. Thanks for updating the example!

@sodabrew sodabrew merged commit debad3c into eventmachine:master Aug 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants