Fix TLS connection of the pure Ruby reactor #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenSSL with a security level >= 2 requires RSA keys to be at least 2048 bits. Since the default cert and key are always set first on a new SSLContext, using a smaller key size causes an exception when starting a TLS connection using the pure Ruby reactor.
|
Thank you! Running CI now |
|
Actually, it occurs to me that the GitHub CI test suite does not have a pure-ruby mode. Would you be up for adding it at least one row to the matrix with one version of Ruby that runs it? |
|
I added a test step. Unfortunately, some tests do still fail (on my Mac) when running It might still be necessary to mark the build test as not required (i.e. something like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these commits, I was able to successfully run
rake test_purewithout any failing tests.