Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and update js environment #554

Closed
wants to merge 68 commits into from

Conversation

FedeG
Copy link
Member

@FedeG FedeG commented Jun 22, 2019

No description provided.

FedeG added 30 commits June 11, 2019 18:37
…' of github.com:eventoL/eventoL into update_dependencies
…b.com:eventoL/eventoL into update_dependencies
…ub.com:eventoL/eventoL into update_dependencies
@FedeG FedeG self-assigned this Jun 22, 2019
@FedeG FedeG added this to In progress in Eventol 2.2 via automation Jun 22, 2019
eventol/front/webpack.prod.config.js Outdated Show resolved Hide resolved
eventol/front/webpack.prod.config.js Show resolved Hide resolved
eventol/front/webpack.prod.config.js Show resolved Hide resolved
eventol/front/webpack.prod.config.js Show resolved Hide resolved
eventol/front/webpack.prod.config.js Show resolved Hide resolved
eventol/front/webpack.local.config.js Outdated Show resolved Hide resolved
eventol/front/webpack.local.config.js Outdated Show resolved Hide resolved
eventol/front/webpack.local.config.js Show resolved Hide resolved
eventol/front/webpack.local.config.js Show resolved Hide resolved
eventol/front/webpack.base.config.js Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jun 22, 2019

Coverage Status

Coverage remained the same at 42.708% when pulling cd95720 on update_dependencies into efe579b on develop.

Copy link

@hound hound bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

�[31mERROR�[0m: Can't parse config file: .jshintrc
�[31mERROR�[0m: Can't parse config file: .jshintrc
Error:TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type object

modulesDirectories: ['node_modules', 'bower_components'],
extensions: ['', '.js', '.jsx']
modules: ['node_modules', 'bower_components'],
extensions: ['.js', '.jsx']
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace '.js',·'.jsx'] with ".js",·".jsx"], prettier/prettier

resolve: {
modulesDirectories: ['node_modules', 'bower_components'],
extensions: ['', '.js', '.jsx']
modules: ['node_modules', 'bower_components'],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'node_modules',·'bower_components' with "node_modules",·"bower_components" prettier/prettier

}
]
},

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete ·· prettier/prettier

{test: /\Toggle.js?$/},
{test: /\effects.js?$/},
],
use: ['babel-loader']
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'babel-loader'] with "babel-loader"], prettier/prettier

{
include: [
{test: /\Toggle.js?$/},
{test: /\effects.js?$/},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary escape character: \e no-useless-escape

},
svgo: {
enabled: true
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Insert , prettier/prettier

quality: 75
},
svgo: {
enabled: true
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Insert , prettier/prettier

interlaced: false
},
webp: {
quality: 75
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Insert , prettier/prettier

speed: 4
},
gifsicle: {
interlaced: false
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Insert , prettier/prettier

},
pngquant: {
quality: '65-90',
speed: 4
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Insert , prettier/prettier

// removes a lot of debugging code in React
new webpack.DefinePlugin({
'process.env': {
NODE_ENV: JSON.stringify('production')
}
}),

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete ·· prettier/prettier

config.plugins = config.plugins.concat([
new BundleTracker({filename: './webpack-stats-prod.json'}),

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete ·· prettier/prettier

})
];

config.mode = 'production';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'production' with "production" prettier/prettier

}
: false,
},
})
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Insert , prettier/prettier

inline: false,
annotation: true,
}
: false,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Insert ·· prettier/prettier

const UglifyJsPlugin = require('uglifyjs-webpack-plugin');
const TerserPlugin = require('terser-webpack-plugin');
const OptimizeCSSAssetsPlugin = require('optimize-css-assets-webpack-plugin');
const safePostCssParser = require('postcss-safe-parser');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'postcss-safe-parser' with "postcss-safe-parser" prettier/prettier

@@ -1,33 +1,68 @@
const webpack = require('webpack');
const config = require('./webpack.base.config.js');
const BundleTracker = require('webpack-bundle-tracker');
const UglifyJsPlugin = require('uglifyjs-webpack-plugin');
const TerserPlugin = require('terser-webpack-plugin');
const OptimizeCSSAssetsPlugin = require('optimize-css-assets-webpack-plugin');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'optimize-css-assets-webpack-plugin' with "optimize-css-assets-webpack-plugin" prettier/prettier

@@ -1,33 +1,68 @@
const webpack = require('webpack');
const config = require('./webpack.base.config.js');
const BundleTracker = require('webpack-bundle-tracker');
const UglifyJsPlugin = require('uglifyjs-webpack-plugin');
const TerserPlugin = require('terser-webpack-plugin');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'terser-webpack-plugin' with "terser-webpack-plugin" prettier/prettier

@@ -1,33 +1,68 @@
const webpack = require('webpack');
const config = require('./webpack.base.config.js');
const BundleTracker = require('webpack-bundle-tracker');
const UglifyJsPlugin = require('uglifyjs-webpack-plugin');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'uglifyjs-webpack-plugin' with "uglifyjs-webpack-plugin" prettier/prettier

};

config.mode = 'development'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'development' with "development"; prettier/prettier

config.plugins = config.plugins.concat([
new BundleTracker({filename: './webpack-stats-prod.json'}),

// removes a lot of debugging code in React
new webpack.DefinePlugin({
'process.env': {
NODE_ENV: JSON.stringify('production')
}
NODE_ENV: JSON.stringify('production'),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'production' with "production" prettier/prettier

const TerserPlugin = require('terser-webpack-plugin');
const OptimizeCSSAssetsPlugin = require('optimize-css-assets-webpack-plugin');
const safePostCssParser = require('postcss-safe-parser');
const config = require('./webpack.base.config.js');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace './webpack.base.config.js' with "./webpack.base.config.js" prettier/prettier

@@ -1,33 +1,64 @@
/* eslint-disable import/no-extraneous-dependencies */
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definition for rule 'react-hooks/exhaustive-deps' was not found react-hooks/exhaustive-deps
Definition for rule 'react/jsx-props-no-spreading' was not found react/jsx-props-no-spreading
Definition for rule 'react/state-in-constructor' was not found react/state-in-constructor

NODE_ENV: JSON.stringify('development')
}
})
NODE_ENV: JSON.stringify('development'),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'development' with "development" prettier/prettier

};

config.mode = 'development';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'development' with "development" prettier/prettier

{test: /\.jsx?$/, exclude: /node_modules/, loaders: ['babel-loader']},
{
include: [{test: /\Toggle.js?$/}, {test: /\effects.js?$/}],
use: ['babel-loader'],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'babel-loader' with "babel-loader" prettier/prettier

},
{test: /\.jsx?$/, exclude: /node_modules/, loaders: ['babel-loader']},
{
include: [{test: /\Toggle.js?$/}, {test: /\effects.js?$/}],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace test:·/\Toggle.js?$/},·{test:·/\effects.js?$/ with ·test:·/\Toggle.js?$/·},·{·test:·/\effects.js?$/· prettier/prettier
Unnecessary escape character: \T no-useless-escape
Unnecessary escape character: \e no-useless-escape

loader: 'file-loader'
}
]
use: 'file-loader',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'file-loader' with "file-loader" prettier/prettier

enabled: false,
},
pngquant: {
quality: '65-90',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace '65-90' with "65-90" prettier/prettier

use: [
'file-loader',
{
loader: 'image-webpack-loader',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'image-webpack-loader' with "image-webpack-loader" prettier/prettier

optipng: {
enabled: true
use: [
'file-loader',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'file-loader' with "file-loader" prettier/prettier

},
{
test: /\.scss$/,
loader: 'style-loader!css-loader!sass-loader'
use: ['style-loader', 'css-loader', 'sass-loader'],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'style-loader',·'css-loader',·'sass-loader' with "style-loader",·"css-loader",·"sass-loader" prettier/prettier

{
test: /\.css$/,
loader: 'style-loader!css-loader'
use: ['style-loader', 'css-loader'],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'style-loader',·'css-loader' with "style-loader",·"css-loader" prettier/prettier


performance: {
hints: process.env.NODE_ENV === 'production' ? 'warning' : false,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'production'·?·'warning' with "production"·?·"warning" prettier/prettier

},

output: {
path: path.resolve('./eventol/static/bundles/local/'),
filename: '[name]-[hash].js'
filename: '[name]-[hash].js',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace '[name]-[hash].js' with "[name]-[hash].js" prettier/prettier

// Stage 3
"@babel/plugin-syntax-dynamic-import",
"@babel/plugin-syntax-import-meta",
"@babel/plugin-proposal-class-properties",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strings must use singlequote quotes


// Stage 3
"@babel/plugin-syntax-dynamic-import",
"@babel/plugin-syntax-import-meta",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strings must use singlequote quotes

"@babel/plugin-proposal-throw-expressions",

// Stage 3
"@babel/plugin-syntax-dynamic-import",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strings must use singlequote quotes

"@babel/plugin-proposal-function-sent",
"@babel/plugin-proposal-export-namespace-from",
"@babel/plugin-proposal-numeric-separator",
"@babel/plugin-proposal-throw-expressions",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strings must use singlequote quotes

["@babel/plugin-proposal-decorators", { "legacy": true }],
"@babel/plugin-proposal-function-sent",
"@babel/plugin-proposal-export-namespace-from",
"@babel/plugin-proposal-numeric-separator",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strings must use singlequote quotes

warnings: false
}
})
new webpack.optimize.OccurrenceOrderPlugin(),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete , prettier/prettier

NODE_ENV: JSON.stringify('production')
}
NODE_ENV: JSON.stringify('production'),
},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete , prettier/prettier

config.plugins = config.plugins.concat([
new BundleTracker({filename: './webpack-stats-prod.json'}),

// removes a lot of debugging code in React
new webpack.DefinePlugin({
'process.env': {
NODE_ENV: JSON.stringify('production')
}
NODE_ENV: JSON.stringify('production'),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'production'), with "production") prettier/prettier

parser: safePostCssParser,
map: false,
},
}),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete , prettier/prettier

cssProcessorOptions: {
parser: safePostCssParser,
map: false,
},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete , prettier/prettier

new TerserPlugin({
terserOptions: {
parse: {
ecma: 8,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete , prettier/prettier

})
NODE_ENV: JSON.stringify('development'),
},
}),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete , prettier/prettier

}
})
NODE_ENV: JSON.stringify('development'),
},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete , prettier/prettier

NODE_ENV: JSON.stringify('development')
}
})
NODE_ENV: JSON.stringify('development'),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'development'), with "development") prettier/prettier


// Use webpack dev server
config.entry = {
Home: addDevVendors('./src/views/Home'),
EventHome: addDevVendors('./src/views/EventHome'),
Report: addDevVendors('./src/views/Report'),
vendors: ['react', 'babel-polyfill']
vendors: ['react', '@babel/polyfill'],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'react',·'@babel/polyfill'], with "react",·"@babel/polyfill"] prettier/prettier

@@ -1,33 +1,64 @@
/* eslint-disable import/no-extraneous-dependencies */
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definition for rule 'react-hooks/exhaustive-deps' was not found react-hooks/exhaustive-deps
Definition for rule 'react/jsx-props-no-spreading' was not found react/jsx-props-no-spreading
Definition for rule 'react/state-in-constructor' was not found react/state-in-constructor

@@ -1,46 +1,54 @@
/* eslint-disable import/no-extraneous-dependencies */
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definition for rule 'react-hooks/exhaustive-deps' was not found react-hooks/exhaustive-deps
Definition for rule 'react/jsx-props-no-spreading' was not found react/jsx-props-no-spreading
Definition for rule 'react/state-in-constructor' was not found react/state-in-constructor

@@ -1,60 +1,102 @@
/* eslint-disable import/no-extraneous-dependencies,no-unused-vars,no-useless-escape */
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definition for rule 'react-hooks/exhaustive-deps' was not found react-hooks/exhaustive-deps
Definition for rule 'react/jsx-props-no-spreading' was not found react/jsx-props-no-spreading
Definition for rule 'react/state-in-constructor' was not found react/state-in-constructor

@@ -1,4 +1,4 @@
/* eslint-disable no-console */
/* eslint-disable no-console,import/no-extraneous-dependencies */
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definition for rule 'react-hooks/exhaustive-deps' was not found react-hooks/exhaustive-deps
Definition for rule 'react/jsx-props-no-spreading' was not found react/jsx-props-no-spreading
Definition for rule 'react/state-in-constructor' was not found react/state-in-constructor

@@ -0,0 +1,30 @@
module.exports = {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definition for rule 'react-hooks/exhaustive-deps' was not found react-hooks/exhaustive-deps
Definition for rule 'react/jsx-props-no-spreading' was not found react/jsx-props-no-spreading
Definition for rule 'react/state-in-constructor' was not found react/state-in-constructor

@FedeG FedeG closed this Jun 22, 2019
Eventol 2.2 automation moved this from In progress to Done Jun 22, 2019
@FedeG FedeG deleted the update_dependencies branch June 22, 2019 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Eventol 2.2
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants