Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return of interpolated string #31

Merged
merged 1 commit into from
May 26, 2015

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented May 24, 2015

Because of the way we are doing string-replacement and not AST->AST transformation, we are quite sensitive to the order the transforms run.

In this case, if you rewrite the -> and the "# first, the patcher can't find any original characters to target when it tries to insert the return.

eventualbuddha added a commit that referenced this pull request May 26, 2015
Fix return of interpolated string
@eventualbuddha eventualbuddha merged commit fd6255e into decaffeinate:master May 26, 2015
@eventualbuddha
Copy link
Collaborator

Thanks!

@eventualbuddha
Copy link
Collaborator

Released in v1.16.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants