Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time Tracking URL bug #859

Closed
assom974 opened this issue Jun 3, 2020 · 1 comment · Fixed by #917
Closed

Time Tracking URL bug #859

assom974 opened this issue Jun 3, 2020 · 1 comment · Fixed by #917

Comments

@assom974
Copy link

assom974 commented Jun 3, 2020

Version(s) affected: 3.8.2

eventum-question

PHP Version: PHP 7.1.32-1

Description
When opening an issue with a 'Time Tracking' entry, if you click on the time tracking entry you get an error message:
"Sorry, you are not allowed to access this page."
With the URL pointing to :
eventum.*****.com/time_tracking.php?ttr_id=undefined
But if you right-click and choose open in new tab/window the URL is generated correctly and it works:
http://eventum.*****.com/time_tracking.php?ttr_id=3480

How to reproduce
Open an existing issue that has a time tracking entry.
Click on the URL of the time tracking entry and the pop-up will give the error message:
"Sorry, you are not allowed to access this page."

Possible Solution
Right-click and open on a new tab/window fix it.

Additional context
I tried replicating the issue with the latest Eventum version of 3.8.15(on my test VM) and the same problem occurs.

@glensc
Copy link
Member

glensc commented Aug 20, 2020

Looks like it's changed in the browser itself:

this expands to <p> tag what's inside <a> somewhy:

-        const ttr_id = $target.data('ttr-id');
+        const ttr_id = $target.closest('a').data('ttr-id');

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants