Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign event cards #48

Closed
wants to merge 5 commits into from
Closed

Conversation

@Sbaah
Copy link
Contributor

Sbaah commented Oct 19, 2019

Submitting a pull request

First of all, thank you for taking the time to contribute to this project !
Every contribution means a lot to us.

Please make sure you check everything on this list:

  • add your change to the CHANGELOG.md in the respective repository
  • make sure tests pass
  • if your commit does close an existing ticket: use a closing issue keyword (e.g: closes #15) in your commit. This makes live easier for our issue tracker.
  • if possible, test your changes with the deploy preview at least once. Promises made, you will enjoy it 🍔
  • add yourself to the CONTRIBUTORS.md as you like
Sbaah added 4 commits Oct 19, 2019
- Rearrange the date and event time.
- Allowed 30 char values to be loaded
- included a <hr> tag for better organization
@Fohlen

This comment has been minimized.

Copy link
Member

Fohlen commented Oct 20, 2019

Hey @Sbaah I will look at your proposal and let you know what I think!

CHANGELOG.md Outdated Show resolved Hide resolved
@Fohlen Fohlen mentioned this pull request Oct 21, 2019
@Fohlen

This comment has been minimized.

Copy link
Member

Fohlen commented Oct 21, 2019

Hey, I am superseding your work with #51
Do you think this is ok? How do you like the new display?

@Fohlen Fohlen closed this Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.