Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Fake data generator may fail because of non working fake image URLs #1295

Closed
evereq opened this issue Aug 3, 2020 · 2 comments
Closed
Assignees
Labels
type: bug 🐛 Something isn't working
Milestone

Comments

@evereq
Copy link
Member

evereq commented Aug 3, 2020

From customer report:

When I try creating fake data in ever admin using below I am seeing this error in console log and after that script stops running and also product list is empty in shop web screen

image

image

I was able to figure out the issue probably, these 3 images are returning 404. If we remove images it works fine
https://images.pexels.com/photos/629093/pexels-photo-629093.jpeg?auto=compress&cs=tinysrgb&h=350
https://images.pexels.com/photos/1268549/pexels-photo-1268549.jpeg?auto=compress&cs=tinysrgb&h=350
https://images.pexels.com/photos/1246957/pexels-photo-1246957.jpeg?auto=compress&cs=tinysrgb&h=350

@evereq evereq added the type: bug 🐛 Something isn't working label Aug 3, 2020
@evereq evereq added this to the v0.3 milestone Aug 3, 2020
@evereq evereq added this to To do in Ever Demand Platform via automation Aug 3, 2020
@evereq
Copy link
Member Author

evereq commented Aug 3, 2020

@YavorGrancharov I am thinking maybe sometimes during fake data generator work, fake images got generated wrong way and did not load and that cause somehow the whole process of seed stop? Please check how fake product pictures are generated, maybe we need to add there some kind of "try/catch" block, so some products might be generated without images but it did not broke the whole seed process.

evereq added a commit that referenced this issue Aug 4, 2020
@YavorGrancharov
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working
Projects
Development

No branches or pull requests

2 participants