Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: platform French support and Spanish fix #1469

Merged
merged 24 commits into from
Feb 10, 2022

Conversation

Neosoulink
Copy link
Contributor

@Neosoulink Neosoulink commented Feb 10, 2022

💻 What's new

  • shop-mobile-ionic package | Fix of ''ng build error: Invalid version: "15.2-15.3" '' by adding .browserlistrc file rules at the root. See this issue at shop-mobile-ionic package
  • Update ILanguage and all interface dependents interface to support French
  • Add French lang to admin-web-angular package
    • Update common Order entity lang support
  • Add french lang support to admin-web-angular package
  • Add french lang support to carrier-mobile-ionic package
  • Add french lang support & fix Spanish key to merchant-tablet-ionic package
  • Add french lang support & fix Spanish key to shop-mobile-ionic package
  • Add french lang support to shop-web-angular package
  • Add french lang support to shop-web-gatsby package

⚠ Warning:

Although FR language files have been added, some are only copies of the EN language. Unfortunately, I couldn't translate them even because I don't have the right tools for that :).
But I have a track to be able to quickly translate our language JSON files. By using JeffJorczak.auto-translate-json an extension of VsCode.

Here is the list of paths of FR JSON files that must be translated:

  • packages\admin-web-angular\src\assets\i18n\fr-FR.json
  • packages\merchant-tablet-ionic\src\assets\i18n\fr-FR.json
  • packages\shop-web-angular\src\assets\i18n\fr-FR.json

📍 Important: During development, I was very careful and checked that everything was consistent, but I strongly recommend a review of what has been done

🌟Suggestion

I strongly suggest the integration mentioned in this Issue, it will help a lot!

🚧 Before this PR

@Neosoulink Neosoulink added the type: enhancement ✨ New feature or request label Feb 10, 2022
@Neosoulink Neosoulink added this to In progress in Ever Demand Platform via automation Feb 10, 2022
@CLAassistant
Copy link

CLAassistant commented Feb 10, 2022

CLA assistant check
All committers have signed the CLA.

@evereq evereq merged commit 41a6bb3 into develop Feb 10, 2022
Ever Demand Platform automation moved this from In progress to Done Feb 10, 2022
@evereq evereq deleted the feature/platform-french-support branch February 10, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement ✨ New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants