fix: remove query params in create API

ever-co · Apr 29, 2024 · 95ff398 · 95ff398
1 parent 8d6699e
commit 95ff398
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 21 deletions.
diff --git a/packages/core/src/tasks/daily-plan/daily-plan.controller.ts b/packages/core/src/tasks/daily-plan/daily-plan.controller.ts
@@ -72,11 +72,8 @@ export class DailyPlanController extends CrudController<DailyPlan> {
 	@HttpCode(HttpStatus.CREATED)
 	@Post()
 	@UseValidationPipe({ transform: true, whitelist: true })
-	async create(
-		@Body() entity: CreateDailyPlanDTO,
-		@Query() options: PaginationParams<DailyPlan>
-	): Promise<IDailyPlan> {
-		return await this.dailyPlanService.createDailyPlan(entity, options, entity.taskId);
+	async create(@Body() entity: CreateDailyPlanDTO): Promise<IDailyPlan> {
+		return await this.dailyPlanService.createDailyPlan(entity, entity.taskId);
 	}
 
 	/**

diff --git a/packages/core/src/tasks/daily-plan/daily-plan.service.ts b/packages/core/src/tasks/daily-plan/daily-plan.service.ts
@@ -30,11 +30,7 @@ export class DailyPlanService extends TenantAwareCrudService<DailyPlan> {
 	 * @param options
 	 */
 
-	async createDailyPlan(
-		partialEntity: DeepPartial<IDailyPlan>,
-		options: PaginationParams<DailyPlan>,
-		taskId?: ITask['id']
-	): Promise<IDailyPlan> {
+	async createDailyPlan(partialEntity: DeepPartial<IDailyPlan>, taskId?: ITask['id']): Promise<IDailyPlan> {
 		try {
 			const { employeeId } = partialEntity;
 			const currentTenantId = RequestContext.currentTenantId();
@@ -54,17 +50,6 @@ export class DailyPlanService extends TenantAwareCrudService<DailyPlan> {
 
 			const query = this.typeOrmRepository.createQueryBuilder(this.tableName);
 
-			query.setFindOptions({
-				...(isNotEmpty(options) &&
-					isNotEmpty(options.where) && {
-						where: options.where
-					}),
-				...(isNotEmpty(options) &&
-					isNotEmpty(options.relations) && {
-						relations: options.relations
-					})
-			});
-
 			query.where(
 				new Brackets((qb: WhereExpressionBuilder) => {
 					qb.andWhere(p(`"${query.alias}"."date" ${likeOperator} :incomingDate`), {