Feat/#806 adding okr module #1504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evereq
reviewed
Jun 24, 2020
| @@ -15,6 +15,26 @@ export class KeyResultUpdateComponent extends TranslationBaseComponent | |||
| implements OnInit { | |||
| keyResultUpdateForm: FormGroup; | |||
| keyResult: KeyResult; | |||
| hideStatus = false; | |||
| updateStatus: any = [ | |||
There was a problem hiding this comment.
@abinandh15 will there be other (custom) statuses defined? If no, we can use enum maybe? If yes, it's fine, but we would prefer to make this data come from server API in such case.
|
@abinandh15 see my comment above. Also, it needs to work to add more translations everywhere. |
Yes, the update status will be made customizable from the setting page and will be fetched from db. Will update it once settings page is complete. Will add translation keys in my next PR. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.